Change CheckCall behavior when print_error=False

Change CheckCall behavior when print_error=False

We now return the stderr half of the tuple.
This required a clean up of any usage of CheckCall and GIT.Capture.

Patch contributed by Nasser Grainawi <nasser@codeaurora.org>;

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=37650

[M-A Ruel, 2010-01-30 03:09:21]

No test to update? If so, lgtm.

http://codereview.chromium.org/551215/diff/1/2
File gclient_utils.py (right):

http://codereview.chromium.org/551215/diff/1/2#newcode54
gclient_utils.py:54: std_out,std_err = process.communicate()
std_out, std_err

http://codereview.chromium.org/551215/diff/1/2#newcode59
gclient_utils.py:59: return std_out,std_err
idem

[Nasser Grainawi, 2010-01-30 04:49:26]

So about tests; I've looked at the wiki on the gclient google code project, read
the little bit in the tests/README, and I'm going through the source now. I
think I can figure that out, but if you have any pointers you want to share (or
even better, document somewhere), it'd be appreciated.

http://codereview.chromium.org/551215/diff/1/2
File gclient_utils.py (right):

http://codereview.chromium.org/551215/diff/1/2#newcode54
gclient_utils.py:54: std_out,std_err = process.communicate()
On 2010/01/30 03:09:21, Marc-Antoine Ruel wrote:
> std_out, std_err

Done.

http://codereview.chromium.org/551215/diff/1/2#newcode59
gclient_utils.py:59: return std_out,std_err
On 2010/01/30 03:09:21, Marc-Antoine Ruel wrote:
> idem

Done.

[M-A Ruel, 2010-01-30 05:13:16]

On 2010/01/30 04:49:26, Nasser Grainawi wrote:
> So about tests; I've looked at the wiki on the gclient google code project,
read
> the little bit in the tests/README, and I'm going through the source now. I
> think I can figure that out, but if you have any pointers you want to share
(or
> even better, document somewhere), it'd be appreciated.

Just run ./presubmit_support.py *.py and hopefully it'll just pass.

[M-A Ruel, 2010-01-30 05:31:41]

On 2010/01/30 05:13:16, Marc-Antoine Ruel wrote:
> On 2010/01/30 04:49:26, Nasser Grainawi wrote:
> > So about tests; I've looked at the wiki on the gclient google code project,
> read
> > the little bit in the tests/README, and I'm going through the source now. I
> > think I can figure that out, but if you have any pointers you want to share
> (or
> > even better, document somewhere), it'd be appreciated.
> 
> Just run ./presubmit_support.py *.py and hopefully it'll just pass.

Bah, I broke them. Don't bother and commit, I'll fix the tests.

lgtm

[M-A Ruel, 2010-01-30 05:54:42]

On 2010/01/30 05:31:41, Marc-Antoine Ruel wrote:
> Bah, I broke them. Don't bother and commit, I'll fix the tests.

You can sync to latest revision if you want to run the test, I fixed them.

[M-A Ruel, 2010-01-30 22:33:12]

On 2010/01/30 05:54:42, Marc-Antoine Ruel wrote:
> You can sync to latest revision if you want to run the test, I fixed them.

I fixed the tests and uploaded the resulting change at
http://codereview.chromium.org/554146

I also committed the code.

[Nico, 2010-02-01 15:16:09]

On 2010/01/30 22:33:12, Marc-Antoine Ruel wrote:
> On 2010/01/30 05:54:42, Marc-Antoine Ruel wrote:
> > You can sync to latest revision if you want to run the test, I fixed them.
> 
> I fixed the tests and uploaded the resulting change at
> http://codereview.chromium.org/554146
> 
> I also committed the code.

This broke git-try. Here's a patch to fix it (don't have a writeable depot_tools
checkout):

===================================================================
--- git-try	(revision 37691)
+++ git-try	(working copy)
@@ -19,18 +19,18 @@
 def GetRietveldIssueNumber():
   return GIT.Capture(
       ['config', 'branch.%s.rietveldissue' % GIT.GetBranch(None)],
-      error_ok=True)
+      error_ok=True)[0]
 
 
 def GetRietveldPatchsetNumber():
   return GIT.Capture(
       ['config', 'branch.%s.rietveldpatchset' % GIT.GetBranch(None)],
-      error_ok=True)
+      error_ok=True)[0]
 
 
 def GetRietveldServerUrl():
   return GIT.Capture(
-      ['config', 'rietveld.server'], error_ok=True).strip()
+      ['config', 'rietveld.server'], error_ok=True)[0].strip()

[M-A Ruel, 2010-02-01 15:30:44]

Next time please send a review so I can review on my phone so you can
commit right away. Now I had to wait to get my hands on a workstation
to reproduce the change and commit it.

M-A

2010/2/1  <thakis@chromium.org>:
> On 2010/01/30 22:33:12, Marc-Antoine Ruel wrote:
>>
>> On 2010/01/30 05:54:42, Marc-Antoine Ruel wrote:
>> > You can sync to latest revision if you want to run the test, I fixed
>> > them.
>
>> I fixed the tests and uploaded the resulting change at
>> http://codereview.chromium.org/554146
>
>> I also committed the code.
>
> This broke git-try. Here's a patch to fix it (don't have a writeable
> depot_tools
> checkout):
>
> ===================================================================
> --- git-try     (revision 37691)
> +++ git-try     (working copy)
> @@ -19,18 +19,18 @@
>  def GetRietveldIssueNumber():
>   return GIT.Capture(
>       ['config', 'branch.%s.rietveldissue' % GIT.GetBranch(None)],
> -      error_ok=True)
> +      error_ok=True)[0]
>
>
>  def GetRietveldPatchsetNumber():
>   return GIT.Capture(
>       ['config', 'branch.%s.rietveldpatchset' % GIT.GetBranch(None)],
> -      error_ok=True)
> +      error_ok=True)[0]
>
>
>  def GetRietveldServerUrl():
>   return GIT.Capture(
> -      ['config', 'rietveld.server'], error_ok=True).strip()
> +      ['config', 'rietveld.server'], error_ok=True)[0].strip()
>
>
> http://codereview.chromium.org/551215
>