Issue 554146: Change CheckCall behavior when print_error=False

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 554146: Change CheckCall behavior when print_error=False (Closed)

Created:
10 years, 10 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Nasser Grainawi

CC:
chromium-reviews

Visibility:
Public.

Description

Change CheckCall behavior when print_error=False We now return the stderr half of the tuple. This required a clean up of any usage of CheckCall and GIT.Capture. Patch contributed by Nasser Grainawi <nasser@codeaura.org>; TEST=unit tests BUG=none

Patch Set 1 #

Total comments: 1

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -21 lines)			Patch
M	gclient_utils.py	View	2 chunks	+6 lines, -5 lines	0 comments	Download
M	scm.py	View	7 chunks	+12 lines, -12 lines	0 comments	Download
M	tests/gclient_utils_test.py	View	3 chunks	+3 lines, -2 lines	0 comments	Download
M	tests/scm_unittest.py	View	1 chunk	+1 line, -1 line	1 comment	Download
M	trychange.py	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Nasser Grainawi

Thanks for fixing those tests, I think I have some idea of how they work ...

10 years, 10 months ago (2010-01-31 03:44:35 UTC) #1

M-A Ruel

10 years, 10 months ago (2010-01-31 05:51:47 UTC) #2

On 2010/01/31 03:44:35, Nasser Grainawi wrote:
> Thanks for fixing those tests, I think I have some idea of how they work now
:)
> 
> http://codereview.chromium.org/554146/diff/1/5
> File tests/scm_unittest.py (right):
> 
> http://codereview.chromium.org/554146/diff/1/5#newcode130
> tests/scm_unittest.py:130: ).AndReturn(['mini@me.com', ''])
> Shouldn't this be ('mini@me.com', '') since Capture should be returning a
tuple,
> not a list?

Technically, you are correct. In practice, it doesn't matter much.

Expand Messages | Collapse Messages