Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/flip/flip_network_transaction_unittest.cc

Issue 551135: Cleanup the unittest helpers in load_log_unittest.h.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Sync and merge conflicts Created 10 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/load_log_unittest.cc ('k') | net/http/http_cache_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/flip/flip_network_transaction_unittest.cc
===================================================================
--- net/flip/flip_network_transaction_unittest.cc (revision 37380)
+++ net/flip/flip_network_transaction_unittest.cc (working copy)
@@ -1053,9 +1053,8 @@
EXPECT_LT(0u, log->entries().size());
int pos = 0;
// We know the first event at position 0.
- net::ExpectLogContains(log, 0,
- net::LoadLog::TYPE_FLIP_TRANSACTION_INIT_CONNECTION,
- net::LoadLog::PHASE_BEGIN);
+ EXPECT_TRUE(net::LogContainsBeginEvent(
+ *log, 0, net::LoadLog::TYPE_FLIP_TRANSACTION_INIT_CONNECTION));
// For the rest of the events, allow additional events in the middle,
// but expect these to be logged in order.
pos = net::ExpectLogContainsSomewhere(log, 0,
« no previous file with comments | « net/base/load_log_unittest.cc ('k') | net/http/http_cache_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698