Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Unified Diff: net/base/load_log_unittest.cc

Issue 551135: Cleanup the unittest helpers in load_log_unittest.h.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Sync and merge conflicts Created 10 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/load_log_unittest.h ('k') | net/flip/flip_network_transaction_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/load_log_unittest.cc
===================================================================
--- net/base/load_log_unittest.cc (revision 37380)
+++ net/base/load_log_unittest.cc (working copy)
@@ -41,15 +41,16 @@
EXPECT_EQ(3u, log->entries().size());
EXPECT_EQ(0u, log->num_entries_truncated());
- ExpectLogContains(log, 0, MakeTime(0), LoadLog::TYPE_HOST_RESOLVER_IMPL,
- LoadLog::PHASE_BEGIN);
+ EXPECT_TRUE(LogContainsEventAtTime(
+ *log, 0, MakeTime(0), LoadLog::TYPE_HOST_RESOLVER_IMPL,
+ LoadLog::PHASE_BEGIN));
- ExpectLogContains(log, 1, MakeTime(2), LoadLog::TYPE_CANCELLED,
- LoadLog::PHASE_NONE);
+ EXPECT_TRUE(LogContainsEventAtTime(
+ *log, 1, MakeTime(2), LoadLog::TYPE_CANCELLED, LoadLog::PHASE_NONE));
- ExpectLogContains(log, 2, MakeTime(11),
- LoadLog::TYPE_HOST_RESOLVER_IMPL_OBSERVER_ONSTART,
- LoadLog::PHASE_END);
+ EXPECT_TRUE(LogContainsEventAtTime(
+ *log, 2, MakeTime(11), LoadLog::TYPE_HOST_RESOLVER_IMPL_OBSERVER_ONSTART,
+ LoadLog::PHASE_END));
}
// Test that the log's size is strictly bounded.
@@ -68,9 +69,8 @@
EXPECT_EQ(0u, log->num_entries_truncated());
// Check the last entry.
- ExpectLogContains(log, 9, MakeTime(9),
- LoadLog::TYPE_CANCELLED,
- LoadLog::PHASE_NONE);
+ EXPECT_TRUE(LogContainsEventAtTime(
+ *log, 9, MakeTime(9), LoadLog::TYPE_CANCELLED, LoadLog::PHASE_NONE));
// Add three entries while maxed out (will cause truncation)
log->Add(LoadLog::Entry(MakeTime(0),
@@ -87,9 +87,8 @@
EXPECT_EQ(3u, log->num_entries_truncated());
// Check the last entry -- it should be the final entry we added.
- ExpectLogContains(log, 9, MakeTime(2),
- LoadLog::TYPE_CANCELLED,
- LoadLog::PHASE_NONE);
+ EXPECT_TRUE(LogContainsEventAtTime(
+ *log, 9, MakeTime(2), LoadLog::TYPE_CANCELLED, LoadLog::PHASE_NONE));
}
TEST(LoadLogTest, Append) {
@@ -117,14 +116,17 @@
EXPECT_EQ(3u, log1->entries().size());
EXPECT_EQ(0u, log1->num_entries_truncated());
- ExpectLogContains(log1, 0, MakeTime(0), LoadLog::TYPE_HOST_RESOLVER_IMPL,
- LoadLog::PHASE_BEGIN);
+ EXPECT_TRUE(LogContainsEventAtTime(
+ *log1, 0, MakeTime(0), LoadLog::TYPE_HOST_RESOLVER_IMPL,
+ LoadLog::PHASE_BEGIN));
- ExpectLogContains(log1, 1, MakeTime(3), LoadLog::TYPE_CANCELLED,
- LoadLog::PHASE_NONE);
+ EXPECT_TRUE(LogContainsEventAtTime(
+ *log1, 1, MakeTime(3), LoadLog::TYPE_CANCELLED,
+ LoadLog::PHASE_NONE));
- ExpectLogContains(log1, 2, MakeTime(9), LoadLog::TYPE_HOST_RESOLVER_IMPL,
- LoadLog::PHASE_END);
+ EXPECT_TRUE(LogContainsEventAtTime(
+ *log1, 2, MakeTime(9), LoadLog::TYPE_HOST_RESOLVER_IMPL,
+ LoadLog::PHASE_END));
}
TEST(LoadLogTest, AppendWithTruncation) {
@@ -152,8 +154,8 @@
EXPECT_EQ(2u, log1->num_entries_truncated());
// Combined log should end with the final entry of log2.
- ExpectLogContains(log1, 9, MakeTime(10), LoadLog::TYPE_CANCELLED,
- LoadLog::PHASE_NONE);
+ EXPECT_TRUE(LogContainsEventAtTime(
+ *log1, 9, MakeTime(10), LoadLog::TYPE_CANCELLED, LoadLog::PHASE_NONE));
}
TEST(LoadLogTest, EventTypeToString) {
« no previous file with comments | « net/base/load_log_unittest.h ('k') | net/flip/flip_network_transaction_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698