Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: net/http/http_cache_unittest.cc

Issue 551135: Cleanup the unittest helpers in load_log_unittest.h.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Sync and merge conflicts Created 10 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/flip/flip_network_transaction_unittest.cc ('k') | net/proxy/init_proxy_resolver_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_cache_unittest.cc
===================================================================
--- net/http/http_cache_unittest.cc (revision 37380)
+++ net/http/http_cache_unittest.cc (working copy)
@@ -905,14 +905,14 @@
// Check that the LoadLog was filled as expected.
// (We attempted to both Open and Create entries, but both failed).
EXPECT_EQ(4u, log->entries().size());
- net::ExpectLogContains(log, 0, net::LoadLog::TYPE_HTTP_CACHE_OPEN_ENTRY,
- net::LoadLog::PHASE_BEGIN);
- net::ExpectLogContains(log, 1, net::LoadLog::TYPE_HTTP_CACHE_OPEN_ENTRY,
- net::LoadLog::PHASE_END);
- net::ExpectLogContains(log, 2, net::LoadLog::TYPE_HTTP_CACHE_CREATE_ENTRY,
- net::LoadLog::PHASE_BEGIN);
- net::ExpectLogContains(log, 3, net::LoadLog::TYPE_HTTP_CACHE_CREATE_ENTRY,
- net::LoadLog::PHASE_END);
+ EXPECT_TRUE(net::LogContainsBeginEvent(
+ *log, 0, net::LoadLog::TYPE_HTTP_CACHE_OPEN_ENTRY));
+ EXPECT_TRUE(net::LogContainsEndEvent(
+ *log, 1, net::LoadLog::TYPE_HTTP_CACHE_OPEN_ENTRY));
+ EXPECT_TRUE(net::LogContainsBeginEvent(
+ *log, 2, net::LoadLog::TYPE_HTTP_CACHE_CREATE_ENTRY));
+ EXPECT_TRUE(net::LogContainsEndEvent(
+ *log, 3, net::LoadLog::TYPE_HTTP_CACHE_CREATE_ENTRY));
EXPECT_EQ(1, cache.network_layer()->transaction_count());
EXPECT_EQ(0, cache.disk_cache()->open_count());
@@ -988,18 +988,18 @@
// Check that the LoadLog was filled as expected.
EXPECT_EQ(6u, log->entries().size());
- net::ExpectLogContains(log, 0, net::LoadLog::TYPE_HTTP_CACHE_OPEN_ENTRY,
- net::LoadLog::PHASE_BEGIN);
- net::ExpectLogContains(log, 1, net::LoadLog::TYPE_HTTP_CACHE_OPEN_ENTRY,
- net::LoadLog::PHASE_END);
- net::ExpectLogContains(log, 2, net::LoadLog::TYPE_HTTP_CACHE_CREATE_ENTRY,
- net::LoadLog::PHASE_BEGIN);
- net::ExpectLogContains(log, 3, net::LoadLog::TYPE_HTTP_CACHE_CREATE_ENTRY,
- net::LoadLog::PHASE_END);
- net::ExpectLogContains(log, 4, net::LoadLog::TYPE_HTTP_CACHE_WAITING,
- net::LoadLog::PHASE_BEGIN);
- net::ExpectLogContains(log, 5, net::LoadLog::TYPE_HTTP_CACHE_WAITING,
- net::LoadLog::PHASE_END);
+ EXPECT_TRUE(net::LogContainsBeginEvent(
+ *log, 0, net::LoadLog::TYPE_HTTP_CACHE_OPEN_ENTRY));
+ EXPECT_TRUE(net::LogContainsEndEvent(
+ *log, 1, net::LoadLog::TYPE_HTTP_CACHE_OPEN_ENTRY));
+ EXPECT_TRUE(net::LogContainsBeginEvent(
+ *log, 2, net::LoadLog::TYPE_HTTP_CACHE_CREATE_ENTRY));
+ EXPECT_TRUE(net::LogContainsEndEvent(
+ *log, 3, net::LoadLog::TYPE_HTTP_CACHE_CREATE_ENTRY));
+ EXPECT_TRUE(net::LogContainsBeginEvent(
+ *log, 4, net::LoadLog::TYPE_HTTP_CACHE_WAITING));
+ EXPECT_TRUE(net::LogContainsEndEvent(
+ *log, 5, net::LoadLog::TYPE_HTTP_CACHE_WAITING));
// force this transaction to read from the cache
MockTransaction transaction(kSimpleGET_Transaction);
@@ -1011,18 +1011,18 @@
// Check that the LoadLog was filled as expected.
EXPECT_EQ(6u, log->entries().size());
- net::ExpectLogContains(log, 0, net::LoadLog::TYPE_HTTP_CACHE_OPEN_ENTRY,
- net::LoadLog::PHASE_BEGIN);
- net::ExpectLogContains(log, 1, net::LoadLog::TYPE_HTTP_CACHE_OPEN_ENTRY,
- net::LoadLog::PHASE_END);
- net::ExpectLogContains(log, 2, net::LoadLog::TYPE_HTTP_CACHE_WAITING,
- net::LoadLog::PHASE_BEGIN);
- net::ExpectLogContains(log, 3, net::LoadLog::TYPE_HTTP_CACHE_WAITING,
- net::LoadLog::PHASE_END);
- net::ExpectLogContains(log, 4, net::LoadLog::TYPE_HTTP_CACHE_READ_INFO,
- net::LoadLog::PHASE_BEGIN);
- net::ExpectLogContains(log, 5, net::LoadLog::TYPE_HTTP_CACHE_READ_INFO,
- net::LoadLog::PHASE_END);
+ EXPECT_TRUE(net::LogContainsBeginEvent(
+ *log, 0, net::LoadLog::TYPE_HTTP_CACHE_OPEN_ENTRY));
+ EXPECT_TRUE(net::LogContainsEndEvent(
+ *log, 1, net::LoadLog::TYPE_HTTP_CACHE_OPEN_ENTRY));
+ EXPECT_TRUE(net::LogContainsBeginEvent(
+ *log, 2, net::LoadLog::TYPE_HTTP_CACHE_WAITING));
+ EXPECT_TRUE(net::LogContainsEndEvent(
+ *log, 3, net::LoadLog::TYPE_HTTP_CACHE_WAITING));
+ EXPECT_TRUE(net::LogContainsBeginEvent(
+ *log, 4, net::LoadLog::TYPE_HTTP_CACHE_READ_INFO));
+ EXPECT_TRUE(net::LogContainsEndEvent(
+ *log, 5, net::LoadLog::TYPE_HTTP_CACHE_READ_INFO));
EXPECT_EQ(1, cache.network_layer()->transaction_count());
EXPECT_EQ(1, cache.disk_cache()->open_count());
« no previous file with comments | « net/flip/flip_network_transaction_unittest.cc ('k') | net/proxy/init_proxy_resolver_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698