Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 551048: Very small optimization of ARM compare stub. (Closed)

Created:
10 years, 11 months ago by Erik Corry
Modified:
9 years, 7 months ago
Reviewers:
Lasse Reichstein
CC:
v8-dev
Visibility:
Public.

Description

Small optimization of ARM compare stub. Reverse all references to left and right sides of the comparison to reflect reality. Don't check explicitly for NaNs when using VFP3 since the compare operation can signal this case with the v flag. Use cmp instead of tst in the fast compilers since tst leaves the v flag unchanged and thus can only work by accident on non-equality comparisons. Committed: http://code.google.com/p/v8/source/detail?r=3625

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -54 lines) Patch
M src/arm/codegen-arm.cc View 1 2 13 chunks +64 lines, -46 lines 0 comments Download
M src/arm/fast-codegen-arm.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/arm/simulator-arm.cc View 1 chunk +6 lines, -1 line 0 comments Download
M src/assembler.cc View 2 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Erik Corry
10 years, 11 months ago (2010-01-15 14:16:24 UTC) #1
Erik Corry
10 years, 11 months ago (2010-01-15 22:57:13 UTC) #2
Lasse Reichstein
10 years, 11 months ago (2010-01-17 11:52:00 UTC) #3
LGTM

http://codereview.chromium.org/551048/diff/1002/2002
File src/assembler.cc (right):

http://codereview.chromium.org/551048/diff/1002/2002#newcode709
src/assembler.cc:709: return fmod(x, y);
Using fmod is bad on Windows 64.
Use modulo(x,y) from platform.h instead.

Powered by Google App Engine
This is Rietveld 408576698