Issue 546026: Adds unit tests for glDrawArrays and glDrawBuffers...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 546026: Adds unit tests for glDrawArrays and glDrawBuffers... (Closed)

Created:
10 years, 11 months ago by greggman

Modified:
9 years, 7 months ago

Reviewers:
apatrick, apatrick_chromium

CC:
apatrick_chromium

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Adds unit tests for glDrawArrays and glDrawBuffers in the GLES2Decoder class of command buffers. Also fixes a few bugs related to validating buffer access and reporting GL errors I also separated out the id mapping, buffer tracking and program tracking into separate classes as different decoders will need to share instances of those classes once we allow sharing of resources. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=36178

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+778 lines, -194 lines)			Patch
M	gpu/command_buffer/build_gles2_cmd_buffer.py	View	1 2	3 chunks	+11 lines, -2 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder.cc	View	1 2	34 chunks	+264 lines, -158 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder_autogen.h	View	1 2	25 chunks	+27 lines, -27 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc	View	1 2	8 chunks	+466 lines, -7 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_validation_autogen.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_validation_implementation_autogen.h	View	1 2	1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

greggman

ping. Sorry if you already saw this. I'd just like to try to get it ...

10 years, 11 months ago (2010-01-13 20:21:15 UTC) #2

LGTM

Expand Messages | Collapse Messages