Issue 5383001: Revert 67293 BrowserTestCanLaunchWithOSMesa was consistently failing - Initia...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5383001: Revert 67293 BrowserTestCanLaunchWithOSMesa was consistently failing - Initia... (Closed)

Created:
10 years, 1 month ago by Bons

Modified:
9 years, 5 months ago

Reviewers:
greggman

CC:
chromium-reviews, vrk (LEFT CHROMIUM), fbarchard, ddorwin+watch_chromium.org, Alpha Left Google, apatrick_chromium, acolwell GONE FROM CHROMIUM, annacc, pam+watch_chromium.org, awong, brettw-cc_chromium.org, darin-cc_chromium.org, scherkus (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 67293 BrowserTestCanLaunchWithOSMesa was consistently failing - Initialize destinations variables before calling GL functions because if the context is lost those variables will be uninitialized. TEST=ran chrome, conformance tests, unit tests and hand edited gles2_demo to test BUG=none Review URL: http://codereview.chromium.org/5305005 TBR=gman@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67328

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -118 lines)			Patch
M	app/gfx/gl/gl_context.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/gpu/gpu_info_collector_mac.mm	View	1 chunk	+3 lines, -5 lines	0 comments	Download
M	chrome/renderer/webgraphicscontext3d_command_buffer_impl.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	gpu/command_buffer/build_gles2_cmd_buffer.py	View	8 chunks	+0 lines, -37 lines	0 comments	Download
M	gpu/command_buffer/client/gles2_c_lib.cc	View	1 chunk	+0 lines, -28 lines	0 comments	Download
M	gpu/command_buffer/client/gles2_c_lib_autogen.h	View	9 chunks	+0 lines, -22 lines	0 comments	Download
M	gpu/command_buffer/client/gles2_demo_cc.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	gpu/command_buffer/service/common_decoder.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gpu/command_buffer/service/common_decoder.cc	View	1 chunk	+3 lines, -8 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder.cc	View	5 chunks	+5 lines, -5 lines	0 comments	Download
M	media/tools/player_x11/gl_video_renderer.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	media/tools/player_x11/gles_video_renderer.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages