Issue 5338004: Cleanup mock device management backend

Issue 5338004: Cleanup mock device management backend (Closed)

Created:
10 years ago by danno

Modified:
9 years, 7 months ago

Reviewers:
gfeher, Mattias Nissler (ping if slow), Jakob Kummerow

CC:
chromium-reviews, ben+cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Cleanup mock device management backend Add actions for mock device management backend for request success and failure. BUG=62482 TEST=DeviceManagementPolicyProviderTest*:DeviceTokenFetcherTest* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67255

Patch Set 1 #

Patch Set 2 : remove dead code #

Total comments: 2

Patch Set 3 : remove dead code #

Total comments: 1

Patch Set 4 : action name should associate with mock backend #

Patch Set 5 : naming tweaks #

Patch Set 6 : merge with latest #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+91 lines, -242 lines)			Patch
M	chrome/browser/policy/device_management_policy_provider_unittest.cc	View	1 2 3 4	7 chunks	+42 lines, -17 lines	0 comments	Download
M	chrome/browser/policy/device_token_fetcher_unittest.cc	View	1 2 3 4	6 chunks	+16 lines, -14 lines	0 comments	Download
M	chrome/browser/policy/mock_device_management_backend.h	View	1 2 3 4	2 chunks	+33 lines, -47 lines	0 comments	Download
D	chrome/browser/policy/mock_device_management_backend.cc	View		1 chunk	+0 lines, -163 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 2 3 4 5	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

gfeher

I don't fully understand the deeper logic yet, but here is a nit. http://codereview.chromium.org/5338004/diff/2001/chrome/browser/policy/device_management_policy_provider_unittest.cc File ...

10 years ago (2010-11-24 09:11:53 UTC) #2

danno

http://codereview.chromium.org/5338004/diff/2001/chrome/browser/policy/device_management_policy_provider_unittest.cc File chrome/browser/policy/device_management_policy_provider_unittest.cc (right): http://codereview.chromium.org/5338004/diff/2001/chrome/browser/policy/device_management_policy_provider_unittest.cc#newcode174 chrome/browser/policy/device_management_policy_provider_unittest.cc:174: // backend_->RegisterFailsOncePolicyFailsTwice(); On 2010/11/24 09:11:53, gfeher wrote: > Nit: ...

10 years ago (2010-11-24 09:19:33 UTC) #3

Jakob Kummerow

LGTM (with the "M" being a provisional committer). Very nice patch!

10 years ago (2010-11-24 09:47:50 UTC) #4

Mattias Nissler (ping if slow)

/me likes this! gmock FTW! Just a small nit. http://codereview.chromium.org/5338004/diff/6001/chrome/browser/policy/mock_device_management_backend.h File chrome/browser/policy/mock_device_management_backend.h (right): http://codereview.chromium.org/5338004/diff/6001/chrome/browser/policy/mock_device_management_backend.h#newcode53 chrome/browser/policy/mock_device_management_backend.h:53: ...

10 years ago (2010-11-24 09:51:21 UTC) #5

gfeher

On 2010/11/24 09:51:21, Mattias Nissler wrote: > /me likes this! gmock FTW! > > Just ...

10 years ago (2010-11-24 10:53:24 UTC) #6

danno

mattias, take a look at the name change and let me know if you think ...

10 years ago (2010-11-24 11:01:21 UTC) #7

Mattias Nissler (ping if slow)

10 years ago (2010-11-24 11:24:33 UTC) #8

On 2010/11/24 11:01:21, danno wrote:
> mattias, take a look at the name change and let me know if you think it's ok.
-
> Danno

I'm okay with this although I'd pref MockDeviceManagementBackend as a prefix to
these actions. I'll leave this decision to you. LGTM.

Expand Messages | Collapse Messages