Cleanup mock device management backend

chrome/browser/policy/mock_device_management_backend.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_POLICY_MOCK_DEVICE_MANAGEMENT_BACKEND_H_
 #define CHROME_BROWSER_POLICY_MOCK_DEVICE_MANAGEMENT_BACKEND_H_
 #pragma once
 
 #include <map>
 #include <string>
 
 #include "base/values.h"
 #include "chrome/browser/policy/device_management_backend.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace policy {
 
 namespace em = enterprise_management;
 
 // Useful for unit testing when a server-based backend isn't
 // available. Simulates both successful and failed requests to the device
 // management server.
 class MockDeviceManagementBackend
     : public DeviceManagementBackend {
  public:
-  MockDeviceManagementBackend();
-  virtual ~MockDeviceManagementBackend();
+  MockDeviceManagementBackend() {}
+  virtual ~MockDeviceManagementBackend() {}
 
   // DeviceManagementBackend method overrides:
   MOCK_METHOD4(ProcessRegisterRequest, void(
       const std::string& auth_token,
       const std::string& device_id,
       const em::DeviceRegisterRequest& request,
       DeviceRegisterResponseDelegate* delegate));
 
   MOCK_METHOD4(ProcessUnregisterRequest, void(
       const std::string& device_management_token,
       const std::string& device_id,
       const em::DeviceUnregisterRequest& request,
       DeviceUnregisterResponseDelegate* delegate));
 
   MOCK_METHOD4(ProcessPolicyRequest, void(
       const std::string& device_management_token,
       const std::string& device_id,
       const em::DevicePolicyRequest& request,
       DevicePolicyResponseDelegate* delegate));
 
-  void AllShouldSucceed();
-  void AllShouldFail();
-  void UnmanagedDevice();
-  void RegisterFailsOncePolicyFailsTwice();
-  void AllWorksFirstPolicyFailsLater();
-
-  void SimulateSuccessfulRegisterRequest(
-      const std::string& auth_token,
-      const std::string& device_id,
-      const em::DeviceRegisterRequest& request,
-      DeviceRegisterResponseDelegate* delegate);
-
-  void SimulateSuccessfulPolicyRequest(
-      const std::string& device_management_token,
-      const std::string& device_id,
-      const em::DevicePolicyRequest& request,
-      DevicePolicyResponseDelegate* delegate);
-
-  void SimulateFailedRegisterRequest(
-      const std::string& auth_token,
-      const std::string& device_id,
-      const em::DeviceRegisterRequest& request,
-      DeviceRegisterResponseDelegate* delegate);
-
-  void SimulateFailedPolicyRequest(
-      const std::string& device_management_token,
-      const std::string& device_id,
-      const em::DevicePolicyRequest& request,
-      DevicePolicyResponseDelegate* delegate);
-
-  void SimulateUnmanagedRegisterRequest(
-      const std::string& auth_token,
-      const std::string& device_id,
-      const em::DeviceRegisterRequest& request,
-      DeviceRegisterResponseDelegate* delegate);
-
-  void AddBooleanPolicy(const char* policy_name, bool value);
-
  private:
-  em::DevicePolicyResponse policy_response_;
-  em::DevicePolicySetting* policy_setting_;
-
-  int policy_remaining_fail_count_;
-  int register_remaining_fail_count_;
-  int policy_remaining_success_count_;
-
   DISALLOW_COPY_AND_ASSIGN(MockDeviceManagementBackend);
 };
 
+ACTION(SucceedRegister) {

[Mattias Nissler (ping if slow), 2010/11/24 09:51:21]

Hm, so we're putting these actions into the policy namespace? I think the name
should then somehow reflect that they belong to the mock backend.

+  em::DeviceRegisterResponse response;
+  std::string token("FAKE_DEVICE_TOKEN_");
+  static int next_token_suffix;
+  token += next_token_suffix++;
+  response.set_device_management_token(token);
+  arg3->HandleRegisterResponse(response);
+}
+
+ACTION_P2(SucceedBooleanPolicy, name, value) {
+  em::DevicePolicyResponse response;
+  em::DevicePolicySetting* setting = response.add_setting();
+  setting->set_policy_key("chrome-policy");
+  setting->set_watermark("fresh");
+  em::GenericSetting* policy_value = setting->mutable_policy_value();
+  em::GenericNamedValue* named_value = policy_value->add_named_value();
+  named_value->set_name(name);
+  named_value->mutable_value()->set_value_type(
+      em::GenericValue::VALUE_TYPE_BOOL);
+  named_value->mutable_value()->set_bool_value(value);
+  arg3->HandlePolicyResponse(response);
+}
+
+ACTION_P(FailRegister, error) {
+  arg3->OnError(error);
+}
+
+ACTION_P(FailPolicy, error) {
+  arg3->OnError(error);
+}
+
 }  // namespace policy
 
 #endif  // CHROME_BROWSER_POLICY_MOCK_DEVICE_MANAGEMENT_BACKEND_H_