Issue 5283002: Addressing the comment in codereview.chromium.org/5151006.

Issue 5283002: Addressing the comment in codereview.chromium.org/5151006. (Closed)

Created:
10 years, 1 month ago by oshima

Modified:
9 years, 6 months ago

Reviewers:
stevenjb, arv (Not doing code reviews), zel

CC:
chromium-reviews, arv (Not doing code reviews), davemoore+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Addressing the comment in codereview.chromium.org/5151006. Fix a bug where page was visible from the beginning. BUG=chromium-os:8285 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67373

Patch Set 3 : timer fix #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -38 lines)			Patch
	M	chrome/browser/chromeos/offline/offline_load_page.cc	View		1 chunk	+1 line, -3 lines	0 comments	Download
	M	chrome/browser/resources/offline_load.html	View	1 2	4 chunks	+21 lines, -35 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

oshima

http://codereview.chromium.org/5283002/diff/10001/chrome/browser/resources/offline_load.html File chrome/browser/resources/offline_load.html (right): http://codereview.chromium.org/5283002/diff/10001/chrome/browser/resources/offline_load.html#newcode69 chrome/browser/resources/offline_load.html:69: <body oncontextmenu="return false;" i18n-values="onload:on_load"> I haven't change this. Please ...

10 years, 1 month ago (2010-11-23 20:45:14 UTC) #1

oshima

zel can you review this? I want to check this is for R9.x. arv, please ...

10 years, 1 month ago (2010-11-24 19:40:30 UTC) #2

arv (Not doing code reviews)

http://codereview.chromium.org/5283002/diff/10001/chrome/browser/resources/offline_load.html File chrome/browser/resources/offline_load.html (right): http://codereview.chromium.org/5283002/diff/10001/chrome/browser/resources/offline_load.html#newcode64 chrome/browser/resources/offline_load.html:64: setTimeout('showPage()', time); Don't use a string as the first ...

10 years, 1 month ago (2010-11-24 19:40:59 UTC) #3

oshima

http://codereview.chromium.org/5283002/diff/10001/chrome/browser/resources/offline_load.html File chrome/browser/resources/offline_load.html (right): http://codereview.chromium.org/5283002/diff/10001/chrome/browser/resources/offline_load.html#newcode64 chrome/browser/resources/offline_load.html:64: setTimeout('showPage()', time); On 2010/11/24 19:40:59, arv wrote: > Don't ...

10 years, 1 month ago (2010-11-24 21:30:11 UTC) #4

stevenjb

My html isn't very strong, but as best I can tell, lgtm.

10 years, 1 month ago (2010-11-25 02:14:43 UTC) #5

oshima

Erik, i'm going to check this in due to time constraints, but please send me ...

10 years, 1 month ago (2010-11-25 02:22:24 UTC) #6

Your HTML seems strong enough to me,

LGTM

Expand Messages | Collapse Messages