Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2202)

Unified Diff: chrome/browser/resources/offline_load.html

Issue 5283002: Addressing the comment in codereview.chromium.org/5151006. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: timer fix Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/offline/offline_load_page.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/offline_load.html
diff --git a/chrome/browser/resources/offline_load.html b/chrome/browser/resources/offline_load.html
index 1c1f002ea35ea9cda55a57e5bf23acd20ed04228..a9756bd8e49ef342070c79e41931fbb4e5018d81 100644
--- a/chrome/browser/resources/offline_load.html
+++ b/chrome/browser/resources/offline_load.html
@@ -18,29 +18,28 @@ body {
color-stop(0.50, rgb(255,255,255))
);
height: 100%;
- padding: 0px;
- margin: 0px;
+ padding: 0;
+ margin: 0;
display: -webkit-box;
-webkit-box-orient: horizontal;
-}
-
-#spacer {
- -webkit-box-flex: 0.5;
+ -webkit-box-pack: center;
+ visibility: hidden;
}
#error {
margin-top: 150px;
- font-size: 24px;
- -webkit-box-flex: 1;
+ font-size: 16px;
display: -webkit-box;
+ width : 800px;
+ max-width: 80%;
-webkit-box-orient: horizontal;
- max-width : 800px;
- width: 80%;
}
#error img {
- margin-right: 10px;
vertical-align: middle;
+ width: 96px;
+ height: 96px;
+ -webkit-margin-end: 10px;
-webkit-box-flex: 0;
}
@@ -49,20 +48,11 @@ body {
-webkit-box-flex: 1;
}
-#heading {
- font-weight: bold;
-}
-
-#msg {
- font-size: 16px;
-}
-
-#msg_box a {
- font-size: 16px;
-}
-
</style>
+<script src="shared/js/local_strings.js"></script>
<script>
+var localStrings = new LocalStrings();
+
function sendCommand(cmd) {
window.domAutomationController.setAutomationId(1);
window.domAutomationController.send(cmd);
@@ -71,21 +61,18 @@ function sendCommand(cmd) {
function showPage() {
document.body.style.visibility = 'visible';
}
-// Start the timer to show the page.
-function startTimer(time) {
- // wait 2.5 seconds before showing 'load now', 'go back' button.
- setTimeout('showPage()', time);
-}
+document.addEventListener('DOMContentLoaded', function() {
+ var timeToWait = localStrings.getString('timeToWait');
+ window.setTimeout(showPage, timeToWait);
+});
</script>
</head>
-<body oncontextmenu="return false;" jsvalues="onload:on_load">
-<div id="spacer"> </div>
-<div id="error" jsvalues=".title:url">
- <img i18n-values=".src:icon;.style.display:display_icon"
- width="96" height="96">
+<body oncontextmenu="return false;">
+<div id="error" i18n-values=".title:url">
+ <img i18n-values=".src:icon;.style.display:display_icon">
<div id="msg_box">
- <div id="headling" i18n-values=".innerText:heading"></div>
+ <h3 i18n-content="heading"></h3>
<div id="msg" i18n-values=".innerHTML:msg"></div>
<button id="continue_button" i18n-content="load_button"
@@ -101,6 +88,5 @@ function startTimer(time) {
</a>
</div>
</div>
-<div id="spacer"> </div>
</body>
</html>
« no previous file with comments | « chrome/browser/chromeos/offline/offline_load_page.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698