Issue 5275001: Adding a test to validate that we don't crash on empty selects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5275001: Adding a test to validate that we don't crash on empty selects. (Closed)

Created:
10 years, 1 month ago by Jay Civelli

Modified:
9 years, 7 months ago

Reviewers:
levin

CC:
chromium-reviews, Paweł Hajdan Jr., darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
http://git.chromium.org/git/chromium.git@trunk

Visibility:
Public.

Adding a test to validate that we don't crash on empty selects. That bug is fixed on the WebKit side with: https://bugs.webkit.org/show_bug.cgi?id=49937 BUG=63774 TEST=On Mac, open a page with a select with not items (<select></select>). Click on the select, nothing should happen. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67886

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -0 lines)			Patch
	M	chrome/renderer/external_popup_menu_unittest.cc	View		3 chunks	+9 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

LGTM