Adding a test to validate that we don't crash on empty selects.

chrome/renderer/external_popup_menu_unittest.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/utf_string_conversions.h"
 #include "chrome/common/render_messages.h"
 #include "chrome/common/render_messages_params.h"
 #include "chrome/test/render_view_test.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "third_party/WebKit/WebKit/chromium/public/WebSize.h"
 #include "third_party/WebKit/WebKit/chromium/public/WebView.h"
 
 // Tests for the external select popup menu (Mac specific).
 
 namespace {
 
 const char* const kSelectID = "mySelect";
+const char* const kEmptySelectID = "myEmptySelect";
 
 }  // namespace
 
 class ExternalPopupMenuTest : public RenderViewTest {
  public:
   ExternalPopupMenuTest() {}
 
   virtual void SetUp() {
     RenderViewTest::SetUp();
     // We need to set this explictly as RenderMain is not run.
     WebKit::WebView::setUseExternalPopupMenus(true);
 
     std::string html = "<select id='mySelect' onchange='selectChanged(this)'>"
                        "  <option>zero</option>"
                        "  <option selected='1'>one</option>"
                        "  <option>two</option>"
+                       "</select>"
+                       "<select id='myEmptySelect'>"
                        "</select>";
     if (ShouldRemoveSelectOnChange()) {
       html += "<script>"
               "  function selectChanged(select) {"
               "    select.parentNode.removeChild(select);"
               "  }"
               "</script>";
     }
 
     // Load the test page.
@@ skipping 58 matching lines @@
   // Click the text field once.
   EXPECT_TRUE(SimulateElementClick(kSelectID));
 
   // Now we navigate to another pager.
   LoadHTML("<blink>Awesome page!</blink>");
 
   // Now the user selects something, we should not crash.
   view_->OnSelectPopupMenuItem(-1);
 }
 
+// An empty select should not cause a crash when clicked.
+// http://crbug.com/63774
+TEST_F(ExternalPopupMenuTest, EmptySelect) {
+  EXPECT_TRUE(SimulateElementClick(kEmptySelectID));
+}
+
 class ExternalPopupMenuRemoveTest : public ExternalPopupMenuTest {
  public:
   ExternalPopupMenuRemoveTest() {}
 
  protected:
   virtual bool ShouldRemoveSelectOnChange() const { return true; }
 };
 
 // Tests that nothing bad happen when the page removes the select when it
 // changes. (http://crbug.com/61997)
 TEST_F(ExternalPopupMenuRemoveTest, RemoveOnChange) {
   // Click the text field once to show the popup.
   EXPECT_TRUE(SimulateElementClick(kSelectID));
 
   // Select something, it causes the select to be removed from the page.
   view_->OnSelectPopupMenuItem(0);
 
   // Just to check the soundness of the test, call SimulateElementClick again.
   // It should return false as the select has been removed.
   EXPECT_FALSE(SimulateElementClick(kSelectID));
 }