Issue 52034: Implement basic ShowItemInFolder for linux....

Issue 52034: Implement basic ShowItemInFolder for linux.... (Closed)

Created:
11 years, 9 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
tony

CC:
chromium-reviews_googlegroups.com, Lei Zhang

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Implement basic ShowItemInFolder for linux. Note that this only works if you are using a gnome or kde session. Support for other sessions will be added in the future. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12395

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+163 lines, -86 lines)			Patch
M	chrome/browser/download/download_file.cc	View	1 2 3	2 chunks	+3 lines, -7 lines	0 comments	Download
M	chrome/browser/download/save_file_manager.cc	View	2 3	3 chunks	+2 lines, -10 lines	0 comments	Download
M	chrome/chrome.gyp	View	1 2 3	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/common/common.scons	View	1 2 3	4 chunks	+7 lines, -0 lines	0 comments	Download
M	chrome/common/common.vcproj	View	3	1 chunk	+8 lines, -0 lines	0 comments	Download
A	chrome/common/platform_util.h	View		1 chunk	+17 lines, -0 lines	0 comments	Download
A	chrome/common/platform_util_linux.cc	View		1 chunk	+28 lines, -0 lines	0 comments	Download
A	chrome/common/platform_util_mac.mm	View	1	1 chunk	+16 lines, -0 lines	0 comments	Download
A	chrome/common/platform_util_win.cc	View	1 2 3	1 chunk	+78 lines, -0 lines	0 comments	Download
M	chrome/common/win_util.h	View	1 2 3	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/common/win_util.cc	View		1 chunk	+0 lines, -66 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

This approach does not work on sessions besides gnome or kde (for example xmonad). Lei ...

11 years, 9 months ago (2009-03-24 00:21:26 UTC) #1

tony

11 years, 9 months ago (2009-03-24 17:12:05 UTC) #2

I see.  Adam and I also discussed what this should do.  Calling xdg-open sounds
good.  It would be nice if we could grey out or remove the menu item if the user
is not using gnome, kde or xcfe.  Another idea was to maybe have xdg-open open a
terminal for directories.  That would probably be a change to xdg-open rather
than chromium code.

Anyway, this LGTM, but I think you need to update common.vcproj as well.

On 2009/03/24 00:21:26, estade wrote:
> This approach does not work on sessions besides gnome or kde (for example
> xmonad). Lei and I (and Dan K) talked about this and decided that xdg-open
needs
> to be fixed. The same is true of selecting items in the folder: this is
> something a lot of apps would want, hence xdg-open needs to take an argument
to
> do that. Lei and I plan to implement these things in xdg-open (or a related
> script) which we'll probably need to pack with chrome.

Expand Messages | Collapse Messages