Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5031)

Unified Diff: chrome/browser/download/download_file.cc

Issue 52034: Implement basic ShowItemInFolder for linux.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/download/save_file_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/download/download_file.cc
===================================================================
--- chrome/browser/download/download_file.cc (revision 12379)
+++ chrome/browser/download/download_file.cc (working copy)
@@ -16,6 +16,7 @@
#include "chrome/browser/tab_contents/tab_util.h"
#include "chrome/browser/tab_contents/web_contents.h"
#include "chrome/common/chrome_paths.h"
+#include "chrome/common/platform_util.h"
#include "chrome/common/stl_util-inl.h"
#include "googleurl/src/gurl.h"
#include "net/base/io_buffer.h"
@@ -517,17 +518,12 @@
// Actions from the UI thread and run on the download thread
-// Open a download, or show it in a Windows Explorer window. We run on this
+// Open a download, or show it in a file explorer window. We run on this
// thread to avoid blocking the UI with (potentially) slow Shell operations.
// TODO(paulg): File 'stat' operations.
void DownloadFileManager::OnShowDownloadInShell(const FilePath& full_path) {
-#if defined(OS_WIN)
DCHECK(MessageLoop::current() == file_loop_);
- win_util::ShowItemInFolder(full_path.value());
-#else
- // TODO(port) implement me.
- NOTREACHED();
-#endif
+ platform_util::ShowItemInFolder(full_path);
}
// Launches the selected download using ShellExecute 'open' verb. If there is
« no previous file with comments | « no previous file | chrome/browser/download/save_file_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698