Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1151)

Unified Diff: chrome/browser/download/save_file_manager.cc

Issue 52034: Implement basic ShowItemInFolder for linux.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/download/download_file.cc ('k') | chrome/chrome.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/download/save_file_manager.cc
===================================================================
--- chrome/browser/download/save_file_manager.cc (revision 12379)
+++ chrome/browser/download/save_file_manager.cc (working copy)
@@ -17,6 +17,7 @@
#include "chrome/browser/tab_contents/tab_util.h"
#include "chrome/browser/tab_contents/web_contents.h"
#include "chrome/common/chrome_paths.h"
+#include "chrome/common/platform_util.h"
#include "chrome/common/stl_util-inl.h"
#include "googleurl/src/gurl.h"
#include "net/base/net_util.h"
@@ -24,10 +25,6 @@
#include "net/url_request/url_request_context.h"
#if defined(OS_WIN)
-#include "chrome/common/win_util.h"
-#endif
-
-#if defined(OS_WIN)
// TODO(port): port these headers to posix.
#include "chrome/browser/tab_contents/tab_contents.h"
#elif defined(OS_POSIX)
@@ -521,12 +518,7 @@
// We run on this thread to avoid blocking the UI with slow Shell operations.
void SaveFileManager::OnShowSavedFileInShell(const FilePath full_path) {
DCHECK(MessageLoop::current() == GetSaveLoop());
- // TODO(port): make an equivalent call on mac/linux.
-#if defined(OS_WIN)
- win_util::ShowItemInFolder(full_path.value());
-#elif defined(OS_POSIX)
- NOTIMPLEMENTED();
-#endif
+ platform_util::ShowItemInFolder(full_path);
}
void SaveFileManager::RenameAllFiles(
« no previous file with comments | « chrome/browser/download/download_file.cc ('k') | chrome/chrome.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698