Extend debugger agent protocol with a connect message

Extend debugger agent protocol with a connect message.Added a name of the embedding application when enabeling the debugger agent.Send a connection message from the debugger agent to the remote debugger when connecting. This message contains the V8 version, the protcol version (currently 1) and the name of the embedding application. Currently this information is just printed raw as received.

Committed: http://code.google.com/p/v8/source/detail?r=1579

[Erik Corry, 2009-03-23 15:39:26]

LGTM

http://codereview.chromium.org/52012/diff/1/11
File SConstruct (right):

http://codereview.chromium.org/52012/diff/1/11#newcode41
Line 41: },
Oops!

http://codereview.chromium.org/52012/diff/1/9
File src/debug-agent.cc (right):

http://codereview.chromium.org/52012/diff/1/9#newcode301
Line 301: "Type: connect\n");
Normally if you have ASCII content on a socket it is sent with cr-lf.  At least
that's what HTTP does and what telnet expects.

http://codereview.chromium.org/52012/diff/1/10
File src/debug-agent.h (right):

http://codereview.chromium.org/52012/diff/1/10#newcode61
Line 61: SmartPointer<const char> name_;  // Name of the embedding application.
I'm not sure you can use a SmartPointer this way.  They are pretty dumb you
know.  :-) Check out the copy constructor for example.  I think this is the
first time someone has tried to use one for a member variable.

[Søren Thygesen Gjesse, 2009-03-23 22:09:23]

http://codereview.chromium.org/52012/diff/1/11
File SConstruct (right):

http://codereview.chromium.org/52012/diff/1/11#newcode41
Line 41: },
On 2009/03/23 15:39:26, Erik Corry wrote:
> Oops!

This file made it into this CL by accident - removed from CL.

http://codereview.chromium.org/52012/diff/1/9
File src/debug-agent.cc (right):

http://codereview.chromium.org/52012/diff/1/9#newcode301
Line 301: "Type: connect\n");
On 2009/03/23 15:39:26, Erik Corry wrote:
> Normally if you have ASCII content on a socket it is sent with cr-lf.  At
least
> that's what HTTP does and what telnet expects.

You are right - I should have checked REF-822/RFC-2616. I will make it compliant
in a new CL.

http://codereview.chromium.org/52012/diff/1/10
File src/debug-agent.h (right):

http://codereview.chromium.org/52012/diff/1/10#newcode61
Line 61: SmartPointer<const char> name_;  // Name of the embedding application.
On 2009/03/23 15:39:26, Erik Corry wrote:
> I'm not sure you can use a SmartPointer this way.  They are pretty dumb you
> know.  :-) Check out the copy constructor for example.  I think this is the
> first time someone has tried to use one for a member variable.

Changed name_(name) to name_(StrDup(name)). This should fill the SmartPointer
with a char array allocated using NewArray.