Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 5184009: Revert 66784 - Converts usage of SetProp/GetProp to a map. Even after making ... (Closed)

Created:
10 years, 1 month ago by sky
Modified:
9 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, ben+cc_chromium.org, brettw-cc_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert 66784 - Converts usage of SetProp/GetProp to a map. Even after making sure we clean up props we still leak in a handful of cases that are causing test grief. By and large our usage of properties is for inside the application, so that a map works fine. BUG=61528 44991 Review URL: http://codereview.chromium.org/5075003 TBR=sky@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66786

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -356 lines) Patch
M app/app.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
M app/app_base.gypi View 2 chunks +0 lines, -4 lines 0 comments Download
D app/view_prop.h View 1 chunk +0 lines, -47 lines 0 comments Download
D app/view_prop.cc View 1 chunk +0 lines, -106 lines 0 comments Download
D app/view_prop_unittest.cc View 1 chunk +0 lines, -70 lines 0 comments Download
M app/win/scoped_prop.h View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/external_tab_container_win.h View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/external_tab_container_win.cc View 6 chunks +11 lines, -9 lines 0 comments Download
MM chrome/browser/renderer_host/render_widget_host_view_win.h View 2 chunks +1 line, -5 lines 0 comments Download
MM chrome/browser/renderer_host/render_widget_host_view_win.cc View 7 chunks +16 lines, -15 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 4 chunks +13 lines, -4 lines 0 comments Download
M views/accessibility/view_accessibility.h View 1 chunk +1 line, -1 line 0 comments Download
M views/accessibility/view_accessibility.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M views/controls/native_control.cc View 5 chunks +7 lines, -8 lines 0 comments Download
M views/controls/native_control_win.h View 3 chunks +5 lines, -3 lines 0 comments Download
M views/controls/native_control_win.cc View 3 chunks +6 lines, -7 lines 0 comments Download
M views/focus/focus_util_win.h View 1 chunk +6 lines, -4 lines 0 comments Download
M views/focus/focus_util_win.cc View 2 chunks +8 lines, -10 lines 0 comments Download
M views/widget/child_window_message_processor.h View 2 chunks +5 lines, -3 lines 0 comments Download
M views/widget/child_window_message_processor.cc View 1 chunk +5 lines, -8 lines 0 comments Download
M views/widget/widget.h View 1 chunk +3 lines, -2 lines 0 comments Download
M views/widget/widget_gtk.h View 1 chunk +3 lines, -2 lines 0 comments Download
M views/widget/widget_gtk.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M views/widget/widget_win.h View 4 chunks +8 lines, -5 lines 0 comments Download
M views/widget/widget_win.cc View 9 chunks +24 lines, -22 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
sky
10 years, 1 month ago (2010-11-19 18:46:56 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698