app/win/scoped_prop.h - Issue 5184009: Revert 66784 - Converts usage of SetProp/GetProp to a map. Even after making ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: app/win/scoped_prop.h

Issue 5184009: Revert 66784 - Converts usage of SetProp/GetProp to a map. Even after making ... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 10 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: app/win/scoped_prop.h

===================================================================

--- app/win/scoped_prop.h (revision 66785)

+++ app/win/scoped_prop.h (working copy)

@@ -18,12 +18,6 @@

// cleanup. ScopedProp must be destroyed before the window is destroyed, else

// you're going to leak a property, which could lead to failure to set a

// property later on.

-//

-// *WARNING*

-// SetProp is very fragile. SetProp makes use of a finite chunk of memory that

-// is very easy to exhaust. Unless you need to share a property across process

-// boundaries you should instead use ViewProp, which does not cause leaks at the

-// window manager.

class ScopedProp {

public:

// Registers the key value pair for the specified window. ScopedProp does not

« no previous file with comments | « app/view_prop_unittest.cc ('k') | chrome/browser/external_tab_container_win.h » ('j') | no next file with comments »