Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(906)

Side by Side Diff: chrome/browser/external_tab_container_win.h

Issue 5184009: Revert 66784 - Converts usage of SetProp/GetProp to a map. Even after making ... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « app/win/scoped_prop.h ('k') | chrome/browser/external_tab_container_win.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTERNAL_TAB_CONTAINER_WIN_H_ 5 #ifndef CHROME_BROWSER_EXTERNAL_TAB_CONTAINER_WIN_H_
6 #define CHROME_BROWSER_EXTERNAL_TAB_CONTAINER_WIN_H_ 6 #define CHROME_BROWSER_EXTERNAL_TAB_CONTAINER_WIN_H_
7 #pragma once 7 #pragma once
8 8
9 #include <map> 9 #include <map>
10 #include <string> 10 #include <string>
(...skipping 13 matching lines...) Expand all
24 #include "chrome/common/notification_registrar.h" 24 #include "chrome/common/notification_registrar.h"
25 #include "views/accelerator.h" 25 #include "views/accelerator.h"
26 #include "views/widget/widget_win.h" 26 #include "views/widget/widget_win.h"
27 27
28 class AutomationProvider; 28 class AutomationProvider;
29 class Profile; 29 class Profile;
30 class TabContentsContainer; 30 class TabContentsContainer;
31 class RenderViewContextMenuViews; 31 class RenderViewContextMenuViews;
32 32
33 namespace app { 33 namespace app {
34 class ViewProp; 34 namespace win {
35 class ScopedProp;
36 }
35 } 37 }
36 38
37 namespace IPC { 39 namespace IPC {
38 struct NavigationInfo; 40 struct NavigationInfo;
39 } 41 }
40 42
41 // This class serves as the container window for an external tab. 43 // This class serves as the container window for an external tab.
42 // An external tab is a Chrome tab that is meant to displayed in an 44 // An external tab is a Chrome tab that is meant to displayed in an
43 // external process. This class provides the FocusManger needed by the 45 // external process. This class provides the FocusManger needed by the
44 // TabContents as well as an implementation of TabContentsDelagate. 46 // TabContents as well as an implementation of TabContentsDelagate.
(...skipping 285 matching lines...) Expand 10 before | Expand all | Expand 10 after
330 332
331 views::View* external_tab_view_; 333 views::View* external_tab_view_;
332 334
333 IPC::Message* unload_reply_message_; 335 IPC::Message* unload_reply_message_;
334 336
335 // set to true if the host needs to get notified of all top level navigations 337 // set to true if the host needs to get notified of all top level navigations
336 // in this page. This typically applies to hosts which would render the new 338 // in this page. This typically applies to hosts which would render the new
337 // page without chrome frame. 339 // page without chrome frame.
338 bool route_all_top_level_navigations_; 340 bool route_all_top_level_navigations_;
339 341
340 scoped_ptr<app::ViewProp> prop_; 342 scoped_ptr<app::win::ScopedProp> prop_;
341 343
342 DISALLOW_COPY_AND_ASSIGN(ExternalTabContainer); 344 DISALLOW_COPY_AND_ASSIGN(ExternalTabContainer);
343 }; 345 };
344 346
345 // This class is instantiated for handling requests to open popups for external 347 // This class is instantiated for handling requests to open popups for external
346 // tabs hosted in browsers which need to be notified about all top level 348 // tabs hosted in browsers which need to be notified about all top level
347 // navigations. An instance of this class is created for handling window.open 349 // navigations. An instance of this class is created for handling window.open
348 // or link navigations with target blank, etc. 350 // or link navigations with target blank, etc.
349 class TemporaryPopupExternalTabContainer : public ExternalTabContainer { 351 class TemporaryPopupExternalTabContainer : public ExternalTabContainer {
350 public: 352 public:
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
400 return false; 402 return false;
401 } 403 }
402 404
403 virtual void BeforeUnloadFired(TabContents* tab, bool proceed, 405 virtual void BeforeUnloadFired(TabContents* tab, bool proceed,
404 bool* proceed_to_fire_unload) { 406 bool* proceed_to_fire_unload) {
405 NOTREACHED(); 407 NOTREACHED();
406 } 408 }
407 }; 409 };
408 410
409 #endif // CHROME_BROWSER_EXTERNAL_TAB_CONTAINER_WIN_H_ 411 #endif // CHROME_BROWSER_EXTERNAL_TAB_CONTAINER_WIN_H_
OLDNEW
« no previous file with comments | « app/win/scoped_prop.h ('k') | chrome/browser/external_tab_container_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698