Issue 517005: After much refactory, finally add significant functionalities to trychanges.py

Issue 517005: After much refactory, finally add significant functionalities to trychanges.py (Closed)

Created:
11 years ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
bradnelson, bradn

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

After much refactory, finally add significant functionalities to trychanges.py Add real logging support. Fix the patch path mungling that was broken earlier. Add and proper refactor automatic gclient and gcl settings detection. Factored so it is possible to add other autodetection algorithms. Now works standalone in hybrid svn&git checkouts within a gclient meta-checkout. TEST=bah BUG=none TBR=bradnelson

Patch Set 1 #

Total comments: 2

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+129 lines, -70 lines)			Patch
M	gcl.py	View	1 chunk	+0 lines, -17 lines	0 comments	Download
M	gclient_utils.py	View	5 chunks	+5 lines, -1 line	2 comments	Download
M	tests/trychange_unittest.py	View	2 chunks	+6 lines, -2 lines	0 comments	Download
M	trychange.py	View	18 chunks	+118 lines, -50 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

bradn

LGTM http://codereview.chromium.org/517005/diff/1/3 File gclient_utils.py (right): http://codereview.chromium.org/517005/diff/1/3#newcode44 gclient_utils.py:44: logging.debug(command) Did you want to make this more ...

11 years ago (2009-12-23 17:30:25 UTC) #2

M-A Ruel

On 2009/12/23 17:30:25, bradn wrote: > LGTM > > http://codereview.chromium.org/517005/diff/1/3 > File gclient_utils.py (right): > ...

11 years ago (2009-12-23 17:42:31 UTC) #3

bradn

11 years ago (2009-12-23 17:44:18 UTC) #4

Ok, fair enough SGTM

On Wed, Dec 23, 2009 at 9:42 AM, <maruel@chromium.org> wrote:

> On 2009/12/23 17:30:25, bradn wrote:
>
>> LGTM
>>
>
>  http://codereview.chromium.org/517005/diff/1/3
>> File gclient_utils.py (right):
>>
>
>  http://codereview.chromium.org/517005/diff/1/3#newcode44
>> gclient_utils.py:44: logging.debug(command)
>> Did you want to make this more verbose? running 'blah'
>>
>
>  http://codereview.chromium.org/517005/diff/1/3#newcode167
>> gclient_utils.py:167: logging.debug(path)
>> Or particularly here: removing directory 'blah'
>>
>
> Blah.
>
> :)
>
> Good comment but will change if I need it to be clearer. Right now it fits
> my
> need and I don't think users will use it much.
>
>
> http://codereview.chromium.org/517005
>

Expand Messages | Collapse Messages