Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Unified Diff: gclient_utils.py

Issue 517005: After much refactory, finally add significant functionalities to trychanges.py (Closed)
Patch Set: Created 11 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gcl.py ('k') | tests/trychange_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gclient_utils.py
diff --git a/gclient_utils.py b/gclient_utils.py
index af9845784a23d603e30350ec6f4c30ac333edd7c..b83f8c9f6740889d16a3db4ddd4e81b50e538bf9 100644
--- a/gclient_utils.py
+++ b/gclient_utils.py
@@ -15,6 +15,7 @@
"""Generic utils."""
import errno
+import logging
import os
import re
import stat
@@ -40,6 +41,7 @@ def CheckCall(command, cwd=None, print_error=True):
Works on python 2.4
"""
+ logging.debug(command)
bradn 2009/12/23 17:30:25 Did you want to make this more verbose? running 'b
try:
stderr = None
if not print_error:
@@ -162,6 +164,7 @@ def RemoveDirectory(*path):
In the ordinary case, this is not a problem: for our purposes, the user
will never lack write permission on *path's parent.
"""
+ logging.debug(path)
bradn 2009/12/23 17:30:25 Or particularly here: removing directory 'blah'
file_path = os.path.join(*path)
if not os.path.exists(file_path):
return
@@ -256,7 +259,7 @@ def SubprocessCallAndFilter(command,
exit with an exit status of fail_status. If fail_status is None (the
default), gclient will raise an Error exception.
"""
-
+ logging.debug(command)
if print_messages:
print("\n________ running \'%s\' in \'%s\'"
% (' '.join(command), in_directory))
@@ -316,6 +319,7 @@ def FindGclientRoot(from_dir):
if not next[1]:
return None
path = next[0]
+ logging.info('Found gclient root at ' + path)
return path
def PathDifference(root, subpath):
« no previous file with comments | « gcl.py ('k') | tests/trychange_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698