Issue 5168004: Revert 66646 - Add "open as window" menu item to NTP app menu....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5168004: Revert 66646 - Add "open as window" menu item to NTP app menu.... (Closed)

Created:
10 years, 1 month ago by Sam Kerner (Chrome)

Modified:
9 years, 7 months ago

Reviewers:
Sam Kerner (Chrome)

CC:
chromium-reviews, ben+cc_chromium.org, Erik does not do reviews, Paweł Hajdan Jr., Aaron Boodman, arv (Not doing code reviews), pam+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 66646 - Add "open as window" menu item to NTP app menu. BUG=59697 TEST=BrowserTest.OpenAppWindowLikeNtp,SessionRestoreUITest.RestoreAfterClosing* Review URL: http://codereview.chromium.org/5019005 TBR=skerner@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66665

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+123 lines, -120 lines)			Patch
M	chrome/app/generated_resources.grd	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/background_application_list_model.cc	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	chrome/browser/browser_browsertest.cc	View	1 chunk	+0 lines, -36 lines	0 comments	Download
M	chrome/browser/dom_ui/app_launcher_handler.cc	View	4 chunks	+3 lines, -21 lines	0 comments	Download
M	chrome/browser/dom_ui/ntp_resource_cache.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/extension_dom_ui.cc	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_prefs.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/extensions/extension_prefs.cc	View	1 chunk	+3 lines, -13 lines	0 comments	Download
M	chrome/browser/extensions/extension_process_manager.cc	View	2 chunks	+9 lines, -5 lines	0 comments	Download
M	chrome/browser/extensions/extension_startup_browsertest.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_toolbar_model.cc	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extensions_service.h	View	2 chunks	+5 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/extensions_service.cc	View	4 chunks	+3 lines, -4 lines	0 comments	Download
M	chrome/browser/resources/new_new_tab.html	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/resources/ntp/apps.js	View	4 chunks	+3 lines, -10 lines	0 comments	Download
M	chrome/browser/sessions/session_restore.cc	View	5 chunks	+53 lines, -1 line	0 comments	Download
M	chrome/browser/tab_contents/render_view_host_delegate_helper.cc	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	chrome/browser/tab_contents/tab_contents.cc	View	1 chunk	+6 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/browser.h	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/browser.cc	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/browser_init.cc	View	1 chunk	+8 lines, -3 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages