Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Unified Diff: chrome/browser/background_application_list_model.cc

Issue 5168004: Revert 66646 - Add "open as window" menu item to NTP app menu.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/browser_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/background_application_list_model.cc
===================================================================
--- chrome/browser/background_application_list_model.cc (revision 66663)
+++ chrome/browser/background_application_list_model.cc (working copy)
@@ -239,7 +239,9 @@
Update();
return;
}
-
+ ExtensionsService* service = profile_->GetExtensionsService();
+ if (!service || !service->is_ready())
+ return;
switch (type.value) {
case NotificationType::EXTENSION_LOADED:
OnExtensionLoaded(Details<Extension>(details).ptr());
@@ -284,6 +286,7 @@
// each observer.
void BackgroundApplicationListModel::Update() {
ExtensionsService* service = profile_->GetExtensionsService();
+ DCHECK(service->is_ready());
// Discover current background applications, compare with previous list, which
// is consistently sorted, and notify observers if they differ.
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/browser_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698