chrome/browser/tab_contents/render_view_host_delegate_helper.cc - Issue 5168004: Revert 66646 - Add "open as window" menu item to NTP app menu....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/tab_contents/render_view_host_delegate_helper.cc

Issue 5168004: Revert 66646 - Add "open as window" menu item to NTP app menu.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 10 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/tab_contents/render_view_host_delegate_helper.cc

===================================================================

--- chrome/browser/tab_contents/render_view_host_delegate_helper.cc (revision 66663)

+++ chrome/browser/tab_contents/render_view_host_delegate_helper.cc (working copy)

@@ -39,7 +39,10 @@

const string16& frame_name) {

ExtensionsService* extensions_service = profile->GetExtensionsService();

- if (!opener_url.is_valid() || frame_name.empty())

+ if (!opener_url.is_valid() ||

+ frame_name.empty() ||

+ !extensions_service ||

+ !extensions_service->is_ready())

return NULL;

const Extension* extension =