Autofill: Prefer maxLength to size attribute for form filling heuristics.

chrome/renderer/form_manager_browsertest.cc

Index: chrome/renderer/form_manager_browsertest.cc
diff --git a/chrome/renderer/form_manager_browsertest.cc b/chrome/renderer/form_manager_browsertest.cc
index 7a948d8119cd2b129602b5ebd7a3dcef73d4410f..1cd8b5f876511150eaa05a3fe0b9d2caae0f6515 100644
--- a/chrome/renderer/form_manager_browsertest.cc
+++ b/chrome/renderer/form_manager_browsertest.cc
@@ -1588,13 +1588,13 @@ TEST_F(FormManagerTest, FillFormMaxLength) {
                       ASCIIToUTF16("firstname"),
                       string16(),
                       ASCIIToUTF16("text"),
-                      20),
+                      5),
             fields[0]);
   EXPECT_EQ(FormField(string16(),
                       ASCIIToUTF16("lastname"),
                       string16(),
                       ASCIIToUTF16("text"),
-                      20),
+                      5),
             fields[1]);
   EXPECT_EQ(FormField(string16(),
                       ASCIIToUTF16("reply-send"),
@@ -1622,13 +1622,13 @@ TEST_F(FormManagerTest, FillFormMaxLength) {
                 ASCIIToUTF16("firstname"),
                 ASCIIToUTF16("Broth"),
                 ASCIIToUTF16("text"),
-                20)));
+                5)));
   EXPECT_TRUE(fields2[1].StrictlyEqualsHack(
       FormField(string16(),
                 ASCIIToUTF16("lastname"),
                 ASCIIToUTF16("Jonat"),
                 ASCIIToUTF16("text"),
-                20)));
+                5)));
   EXPECT_TRUE(fields2[2].StrictlyEqualsHack(
       FormField(string16(),
                 ASCIIToUTF16("reply-send"),
@@ -2332,7 +2332,8 @@ TEST_F(FormManagerTest, SizeFields) {
            "  -"
            "  <input type=\"text\" size=\"3\" name=\"dayphone2\">"
            "  -"
-           "  <input type=\"text\" size=\"4\" name=\"dayphone3\">"
+           "  <input type=\"text\" maxlength=\"4\" size=\"5\""
+           "         name=\"dayphone3\">"
            "  ext.:"
            "  <input type=\"text\" size=\"5\" name=\"dayphone4\">"
            "  <input type=\"text\" name=\"default1\">"
@@ -2340,7 +2341,6 @@ TEST_F(FormManagerTest, SizeFields) {
            "  <input type=\"submit\" name=\"reply-send\" value=\"Send\">"
            "</FORM>");
 
-
   WebFrame* frame = GetMainFrame();
   ASSERT_NE(static_cast<WebFrame*>(NULL), frame);
 
@@ -2371,6 +2371,7 @@ TEST_F(FormManagerTest, SizeFields) {
                       ASCIIToUTF16("text"),
                       3),
             fields[1]);
+  // |maxlength| takes precedence to |size|
   EXPECT_EQ(FormField(ASCIIToUTF16("-"),
                       ASCIIToUTF16("dayphone3"),
                       string16(),