Autofill: Prefer maxLength to size attribute for form filling heuristics.

chrome/renderer/form_manager_browsertest.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/renderer/form_manager.h"
 #include "chrome/test/render_view_test.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "third_party/WebKit/WebKit/chromium/public/WebDocument.h"
@@ skipping 1570 matching lines @@
   EXPECT_EQ(ASCIIToUTF16("TestForm"), form.name);
   EXPECT_EQ(GURL(web_frame->url()), form.origin);
   EXPECT_EQ(GURL("http://buh.com"), form.action);
 
   const std::vector<FormField>& fields = form.fields;
   ASSERT_EQ(3U, fields.size());
   EXPECT_EQ(FormField(string16(),
                       ASCIIToUTF16("firstname"),
                       string16(),
                       ASCIIToUTF16("text"),
-                      20),
+                      5),
             fields[0]);
   EXPECT_EQ(FormField(string16(),
                       ASCIIToUTF16("lastname"),
                       string16(),
                       ASCIIToUTF16("text"),
-                      20),
+                      5),
             fields[1]);
   EXPECT_EQ(FormField(string16(),
                       ASCIIToUTF16("reply-send"),
                       ASCIIToUTF16("Send"),
                       ASCIIToUTF16("submit"),
                       0),
             fields[2]);
 
   // Fill the form.
   form.fields[0].set_value(ASCIIToUTF16("Brother"));
   form.fields[1].set_value(ASCIIToUTF16("Jonathan"));
   EXPECT_TRUE(form_manager.FillForm(form, WebNode()));
 
   // Find the newly-filled form that contains the input element.
   FormData form2;
   EXPECT_TRUE(form_manager.FindFormWithFormControlElement(
       input_element, FormManager::REQUIRE_NONE, &form2));
   EXPECT_EQ(ASCIIToUTF16("TestForm"), form2.name);
   EXPECT_EQ(GURL(web_frame->url()), form2.origin);
   EXPECT_EQ(GURL("http://buh.com"), form2.action);
 
   const std::vector<FormField>& fields2 = form2.fields;
   EXPECT_TRUE(fields2[0].StrictlyEqualsHack(
       FormField(string16(),
                 ASCIIToUTF16("firstname"),
                 ASCIIToUTF16("Broth"),
                 ASCIIToUTF16("text"),
-                20)));
+                5)));
   EXPECT_TRUE(fields2[1].StrictlyEqualsHack(
       FormField(string16(),
                 ASCIIToUTF16("lastname"),
                 ASCIIToUTF16("Jonat"),
                 ASCIIToUTF16("text"),
-                20)));
+                5)));
   EXPECT_TRUE(fields2[2].StrictlyEqualsHack(
       FormField(string16(),
                 ASCIIToUTF16("reply-send"),
                 string16(),
                 ASCIIToUTF16("submit"),
                 0)));
 }
 
 // This test uses negative values of the maxlength attribute for input elements.
 // In this case, the maxlength of the input elements is set to the default
@@ skipping 683 matching lines @@
 }
 
 
 TEST_F(FormManagerTest, SizeFields) {
   LoadHTML("<FORM name=\"TestForm\" action=\"http://cnn.com\" method=\"post\">"
            "  Phone:"
            "  <input type=\"text\" size=\"3\" name=\"dayphone1\">"
            "  -"
            "  <input type=\"text\" size=\"3\" name=\"dayphone2\">"
            "  -"
-           "  <input type=\"text\" size=\"4\" name=\"dayphone3\">"
+           "  <input type=\"text\" maxlength=\"4\" size=\"5\""
+           "         name=\"dayphone3\">"
            "  ext.:"
            "  <input type=\"text\" size=\"5\" name=\"dayphone4\">"
            "  <input type=\"text\" name=\"default1\">"
            "  <input type=\"text\" size=\"-1\" name=\"invalid1\">"
            "  <input type=\"submit\" name=\"reply-send\" value=\"Send\">"
            "</FORM>");
 
-
   WebFrame* frame = GetMainFrame();
   ASSERT_NE(static_cast<WebFrame*>(NULL), frame);
 
   WebVector<WebFormElement> forms;
   frame->forms(forms);
   ASSERT_EQ(1U, forms.size());
 
   FormData form;
   EXPECT_TRUE(FormManager::WebFormElementToFormData(forms[0],
                                                     FormManager::REQUIRE_NONE,
@@ skipping 10 matching lines @@
                       string16(),
                       ASCIIToUTF16("text"),
                       3),
             fields[0]);
   EXPECT_EQ(FormField(ASCIIToUTF16("-"),
                       ASCIIToUTF16("dayphone2"),
                       string16(),
                       ASCIIToUTF16("text"),
                       3),
             fields[1]);
+  // |maxlength| takes precedence to |size|
   EXPECT_EQ(FormField(ASCIIToUTF16("-"),
                       ASCIIToUTF16("dayphone3"),
                       string16(),
                       ASCIIToUTF16("text"),
                       4),
             fields[2]);
   EXPECT_EQ(FormField(ASCIIToUTF16("ext.:"),
                       ASCIIToUTF16("dayphone4"),
                       string16(),
                       ASCIIToUTF16("text"),
@@ skipping 588 matching lines @@
                 0)));
   EXPECT_TRUE(fields[3].StrictlyEqualsHack(
       FormField(string16(),
                 ASCIIToUTF16("reply-send"),
                 string16(),
                 ASCIIToUTF16("submit"),
                 0)));
 }
 
 }  // namespace