Autofill: Prefer maxLength to size attribute for form filling heuristics.

chrome/renderer/form_manager.cc

Index: chrome/renderer/form_manager.cc
diff --git a/chrome/renderer/form_manager.cc b/chrome/renderer/form_manager.cc
index 9855a09b35234eca5a3ea14aad4981ed021ac7b8..f1d2b2c99175cd693c39da6c8d47e8d77827e66c 100644
--- a/chrome/renderer/form_manager.cc
+++ b/chrome/renderer/form_manager.cc
@@ -310,7 +310,12 @@ void FormManager::WebFormControlElementToFormField(
 
   if (element.formControlType() == WebString::fromUTF8("text")) {
     const WebInputElement& input_element = element.toConst<WebInputElement>();
-    field->set_size(input_element.size());
+    // TODO(isherman): Add "524288" as a named constant to the WebKit API

[dhollowa, 2010/11/18 18:26:51]

It looks to me like the use of |size| was misguided originally.  In the original
bug 38218, the problematic site
https://scgi.ebay.com/ws/eBayISAPI.dll?RegisterEnterInfo has a correct
|maxlength| attribute.

Let's go ahead and remove the |size| attribute from webkit_glue::FormField and
replace it with |maxlength|.

I also notice that when submitting the form the saved profile has an incorrect
number.

[Ilya Sherman, 2010/11/19 02:33:44]

Done.
I figured out why this is happening; will address this in a separate cl

+    if (input_element.hasAttribute(WebString::fromUTF8("maxLength")) &&
+        input_element.maxLength() != 524288)
+      field->set_size(input_element.maxLength());
+    else
+      field->set_size(input_element.size());
   }
 
   if (!(extract_mask & EXTRACT_VALUE))