Autofill: Prefer maxLength to size attribute for form filling heuristics.

chrome/renderer/form_manager.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/form_manager.h"
 
 #include "base/logging.h"
 #include "base/scoped_vector.h"
 #include "base/string_util.h"
 #include "base/stl_util-inl.h"
@@ skipping 292 matching lines @@
 
   if (extract_mask & EXTRACT_OPTIONS) {
     // Set option strings on the field if available.
     std::vector<string16> option_strings;
     GetOptionStringsFromElement(element, &option_strings);
     field->set_option_strings(option_strings);
   }
 
   if (element.formControlType() == WebString::fromUTF8("text")) {
     const WebInputElement& input_element = element.toConst<WebInputElement>();
-    field->set_size(input_element.size());
+    // TODO(isherman): Add "524288" as a named constant to the WebKit API

[dhollowa, 2010/11/18 18:26:51]

It looks to me like the use of |size| was misguided originally.  In the original
bug 38218, the problematic site
https://scgi.ebay.com/ws/eBayISAPI.dll?RegisterEnterInfo has a correct
|maxlength| attribute.

Let's go ahead and remove the |size| attribute from webkit_glue::FormField and
replace it with |maxlength|.

I also notice that when submitting the form the saved profile has an incorrect
number.

[Ilya Sherman, 2010/11/19 02:33:44]

Done.
I figured out why this is happening; will address this in a separate cl

+    if (input_element.hasAttribute(WebString::fromUTF8("maxLength")) &&
+        input_element.maxLength() != 524288)
+      field->set_size(input_element.maxLength());
+    else
+      field->set_size(input_element.size());
   }
 
   if (!(extract_mask & EXTRACT_VALUE))
     return;
 
   // TODO(jhawkins): In WebKit, move value() and setValue() to
   // WebFormControlElement.
   string16 value;
   if (element.formControlType() == WebString::fromUTF8("text") ||
       element.formControlType() == WebString::fromUTF8("hidden")) {
@@ skipping 584 matching lines @@
   WebInputElement input_element = field->to<WebInputElement>();
 
   // If the maxlength attribute contains a negative value, maxLength()
   // returns the default maxlength value.
   input_element.setSuggestedValue(
       data->value().substr(0, input_element.maxLength()));
   input_element.setAutofilled(true);
   if (is_initiating_node)
     input_element.setSelectionRange(0, input_element.suggestedValue().length());
 }