Issue 511001: Adds a GLMock object so we can check the code is...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 511001: Adds a GLMock object so we can check the code is... (Closed)

Created:
11 years ago by greggman

Modified:
9 years, 7 months ago

Reviewers:
apatrick, apatrick_chromium

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Adds a GLMock object so we can check the code is correctly calling GL Rather than make a GLBase with all virtual functions I made it compile twice, once for shipping code where it includes the local platform's gl.h and again for unit tests where it includes gl_mock.h. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35210

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1174 lines, -119 lines)			Patch
M	gpu/command_buffer/build_gles2_cmd_buffer.py	View	1 2 3	2 chunks	+1 line, -4 lines	0 comments	Download
M	gpu/command_buffer/common/gles2_cmd_format.h	View	1 2 3	3 chunks	+8 lines, -2 lines	0 comments	Download
M	gpu/command_buffer/common/gles2_cmd_format_autogen.h	View	3	2 chunks	+0 lines, -3 lines	0 comments	Download
A	gpu/command_buffer/service/gl_interface.h	View	2 3	1 chunk	+531 lines, -0 lines	0 comments	Download
A	gpu/command_buffer/service/gl_interface.cc	View		1 chunk	+20 lines, -0 lines	0 comments	Download
A	gpu/command_buffer/service/gl_mock.h	View	1 2 3	1 chunk	+380 lines, -0 lines	0 comments	Download
A	gpu/command_buffer/service/gl_mock.cc	View	1	1 chunk	+11 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/service/gl_utils.h	View	1 2 3	1 chunk	+4 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder.cc	View	1 2 3	10 chunks	+21 lines, -11 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder_autogen.h	View	1 2 3	51 chunks	+84 lines, -84 lines	0 comments	Download
A	gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc	View		1 chunk	+70 lines, -0 lines	0 comments	Download
M	gpu/gpu.gyp	View	1 2 3	7 chunks	+44 lines, -15 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages