Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issue 5091002: Add per board customization, clean up private autotests. (Closed)

Created:
10 years, 1 month ago by Nick Sanders
Modified:
9 years, 7 months ago
Reviewers:
Tammo Spalink, Hung-Te
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

Add per board customization, clean up private autotests. BUG=1583 TEST=actually builds Change-Id: I6510f30faf3f3c2e88b4ea9c63985c09086e1a5d Review URL: http://codereview.chromium.org/4482001 (cherry picked from commit afba119639afe0fb8206e58ead091f2efd114192) Allow branch customization for factory BUG=1583 TEST=removes superfluous files Change-Id: I576fc0dd811f9c1ed6299a539e0e8a014b37bdc8 Review URL: http://codereview.chromium.org/4376001 (cherry picked from commit 08fdc9da26456c286254c250366bdfc738f8ed38) No pagecycler for factory image BUG=1583 TEST="build, no pagecycler in factory." Change-Id: I43d23de5d518634697e17a32bcd94a43aad46aba Review URL: http://codereview.chromium.org/4342002 (cherry picked from commit f3e98785f3ed3f4e87e4287ee3ec45e2fc737c89)

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
A mod_for_factory_scripts/600customizeRelease View 1 chunk +22 lines, -0 lines 4 comments Download
M mod_image_for_test.sh View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nick Sanders
cherry pick from 102.B
10 years, 1 month ago (2010-11-17 03:26:32 UTC) #1
Hung-Te
http://codereview.chromium.org/5091002/diff/1/mod_for_factory_scripts/600customizeRelease File mod_for_factory_scripts/600customizeRelease (right): http://codereview.chromium.org/5091002/diff/1/mod_for_factory_scripts/600customizeRelease#newcode9 mod_for_factory_scripts/600customizeRelease:9: pushd ${TEST_DIR} 1> /dev/null better to be quoted as ...
10 years, 1 month ago (2010-11-17 03:50:21 UTC) #2
Nick Sanders
http://codereview.chromium.org/5091002/diff/1/mod_for_factory_scripts/600customizeRelease File mod_for_factory_scripts/600customizeRelease (right): http://codereview.chromium.org/5091002/diff/1/mod_for_factory_scripts/600customizeRelease#newcode9 mod_for_factory_scripts/600customizeRelease:9: pushd ${TEST_DIR} 1> /dev/null This is to maintain consistency ...
10 years, 1 month ago (2010-11-17 03:59:14 UTC) #3
Nick Sanders
> and address style issues in a separate CL. In which case we should correct ...
10 years, 1 month ago (2010-11-17 04:00:25 UTC) #4
Hung-Te
10 years, 1 month ago (2010-11-17 06:25:25 UTC) #5
LGTM for this to be a direct cherry-pick and for coding style consistency

Powered by Google App Engine
This is Rietveld 408576698