mod_for_factory_scripts/600customizeRelease - Issue 5091002: Add per board customization, clean up private autotests.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: mod_for_factory_scripts/600customizeRelease

Issue 5091002: Add per board customization, clean up private autotests. (Closed) Base URL: ssh://git@gitrw.chromium.org:9222/crosutils.git

Patch Set: Created 10 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 #!/bin/bash

	2

	3 # Copyright (c) 2010 The Chromium OS Authors. All rights reserved.

	4 # Use of this source code is governed by a BSD-style license that can be

	5 # found in the LICENSE file.

	6

	7 TEST_DIR="${ROOT_FS_DIR}/usr/local/autotest/site_tests/suite_Factory"

	8

	9 pushd ${TEST_DIR} 1> /dev/null
	Hung-Te 2010/11/17 03:50:21 better to be quoted as "${TEST_DIR}". And I think better to be quoted as "${TEST_DIR}". And I think we don't need "1>" for stdout - simply ">" is enough. Also there should not be space between redirection symbol and destination file according to shell script coding style guide. In other words, this can be pushd "${TEST_DIR}" >/dev/null P.S: should we abort if TEST_DIR does not exist? Nick Sanders 2010/11/17 03:59:15 This is to maintain consistency with other mod_for This is to maintain consistency with other mod_for factory. I'd prefer to cherry pick this directly, to get TOT matched to the the factory branch, and address style issues in a separate CL.
	10

	11 # If there is a customize_$BOARD script for this board, let's run it.

	12 # This allows adding settings for specific factories or systems.

	13 CUSTOMIZE="customize_${BOARD}"

	14 if [ -e "${CUSTOMIZE}" ]; then

	15 echo "Running ${CUSTOMIZE}"

	16 "./${CUSTOMIZE}"
	Hung-Te 2010/11/17 03:50:21 pushd/popd is sometimes buggy, and is bash-only. S pushd/popd is sometimes buggy, and is bash-only. Since the only place that needs changing directory is one line, I'd more prefer a sub-command like ( cd "${TEST_DIR}" && "./${CUSTOMIZE}" ) and prefix $TEST_DIR to all reference to $CUSTOMIZE and customize_* in this script. However, since current code is working fine, I'm OK if we don't change this part.
	17 fi

	18

	19 # We don't need the customize script anymore.

	20 rm -f customize_*

	21

	22 popd 1> /dev/null
	Hung-Te 2010/11/17 03:50:21 popd >/dev/null popd >/dev/null
OLD	NEW

« no previous file with comments | « no previous file | mod_image_for_test.sh » ('j') | no next file with comments »