Issue 4482001: Fix build break Looks like I messed up the files somehow before push.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4482001: Fix build break Looks like I messed up the files somehow before push. (Closed)

Created:
10 years, 1 month ago by Nick Sanders

Modified:
9 years, 7 months ago

Reviewers:
Tammo Spalink, Hung-Te

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://git@gitrw.chromium.org:9222/crosutils.git

Visibility:
Public.

Description

Fix build break Looks like I messed up the files somehow before push. BUG=1583 TEST=actually builds Change-Id: I6510f30faf3f3c2e88b4ea9c63985c09086e1a5d

Patch Set 2 : fix quotes #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	mod_for_factory_scripts/600customizeRelease	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Hung-Te

LGTM if board won't have space inside. http://codereview.chromium.org/4482001/diff/1/2 File mod_for_factory_scripts/600customizeRelease (right): http://codereview.chromium.org/4482001/diff/1/2#newcode16 mod_for_factory_scripts/600customizeRelease:16: ./${CUSTOMIZE} I ...

10 years, 1 month ago (2010-11-04 09:28:35 UTC) #2

Nick Sanders

http://codereview.chromium.org/4482001/diff/1/2 File mod_for_factory_scripts/600customizeRelease (right): http://codereview.chromium.org/4482001/diff/1/2#newcode16 mod_for_factory_scripts/600customizeRelease:16: ./${CUSTOMIZE} fixed

10 years, 1 month ago (2010-11-04 09:30:58 UTC) #3

LGTM

Expand Messages | Collapse Messages

Issue 4482001: Fix build break Looks like I messed up the files somehow before push. (Closed)

Description

Patch Set 1 #

Patch Set 2 : fix quotes #

Messages