Autofill select field text should be captured not selection option value

Autofill select field text should be captured not selection option value

Sends select field text values to browser when form is submitted.

BUG=49189
TEST=FormManagerTest.SelectOneAsText

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66310

[James Hawkins, 2010-11-16 18:03:12]

http://codereview.chromium.org/5080001/diff/1/chrome/renderer/form_manager.cc
File chrome/renderer/form_manager.cc (right):

http://codereview.chromium.org/5080001/diff/1/chrome/renderer/form_manager.cc...
chrome/renderer/form_manager.cc:340: value =
list_items[i].to<WebOptionElement>().text();
This overwrites the value of the selected option, are we sure this isn't going
to break auto-filling select controls? The API for setting the value of a select
control requires the actual value to be sent in, not the text. Our code to
convert CA <-> California may help us here, but I'm not sure.

http://codereview.chromium.org/5080001/diff/1/chrome/renderer/form_manager.h
File chrome/renderer/form_manager.h (right):

http://codereview.chromium.org/5080001/diff/1/chrome/renderer/form_manager.h#...
chrome/renderer/form_manager.h:42: // Only valid when |EXTRACT_VALUE| is set.
This line bothers me.  What text is it extracting?  Why do we need a new mask
for text?  At the very least, the name needs more, e.g. EXTRACT_OPTION_TEXT.

[dhollowa, 2010-11-16 19:25:57]

http://codereview.chromium.org/5080001/diff/1/chrome/renderer/form_manager.cc
File chrome/renderer/form_manager.cc (right):

http://codereview.chromium.org/5080001/diff/1/chrome/renderer/form_manager.cc...
chrome/renderer/form_manager.cc:340: value =
list_items[i].to<WebOptionElement>().text();
On 2010/11/16 18:03:12, James Hawkins wrote:
> This overwrites the value of the selected option, are we sure this isn't going
> to break auto-filling select controls? The API for setting the value of a
select
> control requires the actual value to be sent in, not the text. Our code to
> convert CA <-> California may help us here, but I'm not sure.

Yes, I verified this case.  We only send the |text| value on form submission. 
So there is no interaction with filling or suggestions.

http://codereview.chromium.org/5080001/diff/1/chrome/renderer/form_manager.h
File chrome/renderer/form_manager.h (right):

http://codereview.chromium.org/5080001/diff/1/chrome/renderer/form_manager.h#...
chrome/renderer/form_manager.h:42: // Only valid when |EXTRACT_VALUE| is set.
On 2010/11/16 18:03:12, James Hawkins wrote:
> This line bothers me.  What text is it extracting?  Why do we need a new mask
> for text?  At the very least, the name needs more, e.g. EXTRACT_OPTION_TEXT.

Done.

[James Hawkins, 2010-11-16 19:28:06]

LGTM