Autofill select field text should be captured not selection option value

chrome/renderer/form_manager.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_RENDERER_FORM_MANAGER_H_
 #define CHROME_RENDERER_FORM_MANAGER_H_
 #pragma once
 
 #include <map>
 #include <vector>
@@ skipping 20 matching lines @@
     REQUIRE_NONE         = 0,       // No requirements.
     REQUIRE_AUTOCOMPLETE = 1 << 0,  // Require that autocomplete != off.
     REQUIRE_ENABLED      = 1 << 1,  // Require that disabled attribute is off.
     REQUIRE_EMPTY        = 1 << 2,  // Require that the fields are empty.
   };
 
   // A bit field mask to extract data from WebFormControlElement.
   enum ExtractMask {
     EXTRACT_NONE    = 0,
     EXTRACT_VALUE   = 1 << 0,  // Extract value from WebFormControlElement.
-    EXTRACT_OPTIONS = 1 << 1,  // Extract options from WebFormControlElement.
+    EXTRACT_TEXT    = 1 << 1,  // Extract text from WebFormSelectElement.
+                               // Only valid when |EXTRACT_VALUE| is set.

[James Hawkins, 2010/11/16 18:03:12]

This line bothers me.  What text is it extracting?  Why do we need a new mask
for text?  At the very least, the name needs more, e.g. EXTRACT_OPTION_TEXT.

[dhollowa, 2010/11/16 19:25:57]

Done.

+    EXTRACT_OPTIONS = 1 << 2,  // Extract options from WebFormControlElement.
   };
 
   FormManager();
   virtual ~FormManager();
 
   // Fills out a FormField object from a given WebFormControlElement.
   // |extract_mask|: See the enum ExtractMask above for details.
   static void WebFormControlElementToFormField(
       const WebKit::WebFormControlElement& element,
       ExtractMask extract_mask,
@@ skipping 116 matching lines @@
                         const webkit_glue::FormField* data,
                         bool is_initiating_node);
 
   // The cached FormElement objects.
   FormElementList form_elements_;
 
   DISALLOW_COPY_AND_ASSIGN(FormManager);
 };
 
 #endif  // CHROME_RENDERER_FORM_MANAGER_H_