Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Unified Diff: chrome/renderer/form_manager.cc

Issue 5080001: Autofill select field text should be captured not selection option value (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/chrome
Patch Set: 80 col. Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/form_manager.h ('k') | chrome/renderer/form_manager_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/form_manager.cc
diff --git a/chrome/renderer/form_manager.cc b/chrome/renderer/form_manager.cc
index 26fe32bb5f1cddc78522ef73f4944bc1f84dfc46..9855a09b35234eca5a3ea14aad4981ed021ac7b8 100644
--- a/chrome/renderer/form_manager.cc
+++ b/chrome/renderer/form_manager.cc
@@ -330,6 +330,18 @@ void FormManager::WebFormControlElementToFormField(
WebFormControlElement& e = const_cast<WebFormControlElement&>(element);
WebSelectElement select_element = e.to<WebSelectElement>();
value = select_element.value();
+
+ // Convert the |select_element| value to text if requested.
+ if (extract_mask & EXTRACT_OPTION_TEXT) {
+ WebVector<WebElement> list_items = select_element.listItems();
+ for (size_t i = 0; i < list_items.size(); ++i) {
+ if (list_items[i].hasTagName("option") &&
+ list_items[i].to<WebOptionElement>().value() == value) {
+ value = list_items[i].to<WebOptionElement>().text();
+ break;
+ }
+ }
+ }
}
// TODO(jhawkins): This is a temporary stop-gap measure designed to prevent
« no previous file with comments | « chrome/renderer/form_manager.h ('k') | chrome/renderer/form_manager_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698