Issue 505016: Implements Validation for all GLenum arguments and ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 505016: Implements Validation for all GLenum arguments and ... (Closed)

Created:
11 years ago by greggman

Modified:
9 years, 7 months ago

Reviewers:
apatrick, apatrick_chromium

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Implements Validation for all GLenum arguments and GLint arguments that have specific valid values. Will add unit tests in separate CL as I expect to be able to auto generate unit tests. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=34726

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2397 lines, -2632 lines)			Patch
M	gpu/command_buffer/build_gles2_cmd_buffer.py	View	1 2 3	31 chunks	+625 lines, -182 lines	0 comments	Download
M	gpu/command_buffer/common/gles2_cmd_id_test.cc	View		2 chunks	+2 lines, -357 lines	0 comments	Download
A	gpu/command_buffer/common/gles2_cmd_id_test_autogen.h	View	1 2	1 chunk	+359 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder.cc	View	1 2 3	17 chunks	+96 lines, -89 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder_autogen.h	View	1 2 3	146 chunks	+743 lines, -742 lines	0 comments	Download
D	gpu/command_buffer/service/gles2_cmd_decoder_validate.h	View		1 chunk	+0 lines, -1262 lines	0 comments	Download
A	gpu/command_buffer/service/gles2_cmd_validation.h	View	1 2 3	1 chunk	+21 lines, -0 lines	0 comments	Download
A	gpu/command_buffer/service/gles2_cmd_validation.cc	View		1 chunk	+22 lines, -0 lines	0 comments	Download
A	gpu/command_buffer/service/gles2_cmd_validation_autogen.h	View		1 chunk	+42 lines, -0 lines	0 comments	Download
A	gpu/command_buffer/service/gles2_cmd_validation_implementation_autogen.h	View	1 2	1 chunk	+487 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages