Issue 49041: WebContentsView became more than just an interface with 48103 (r12483). If we...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 49041: WebContentsView became more than just an interface with 48103 (r12483). If we... (Closed)

Created:
11 years, 9 months ago by Avi (use Gerrit)

Modified:
9 years, 7 months ago

Reviewers:
brettw, Evan Stade

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

WebContentsView became more than just an interface with 48103 (r12483). If we move web_contents_ to the base class, we might as well finish the job. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12555

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+65 lines, -80 lines)			Patch
M	chrome/browser/tab_contents/web_contents_view.h	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/tab_contents/web_contents_view_gtk.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/tab_contents/web_contents_view_gtk.cc	View	5 chunks	+7 lines, -11 lines	0 comments	Download
M	chrome/browser/tab_contents/web_contents_view_mac.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/tab_contents/web_contents_view_mac.mm	View	7 chunks	+17 lines, -21 lines	0 comments	Download
M	chrome/browser/tab_contents/web_contents_view_win.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/tab_contents/web_contents_view_win.cc	View	17 chunks	+37 lines, -41 lines	0 comments	Download

Total messages: 2 (0 generated)

LGTM, thanks for doing this.