Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Unified Diff: chrome/browser/tab_contents/web_contents_view.h

Issue 49041: WebContentsView became more than just an interface with 48103 (r12483). If we... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/tab_contents/web_contents_view_gtk.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/tab_contents/web_contents_view.h
===================================================================
--- chrome/browser/tab_contents/web_contents_view.h (revision 12546)
+++ chrome/browser/tab_contents/web_contents_view.h (working copy)
@@ -42,7 +42,7 @@
// the caller.
static WebContentsView* Create(WebContents* web_contents);
- virtual WebContents* GetWebContents() = 0;
+ WebContents* web_contents() const { return web_contents_; }
virtual void CreateView() = 0;
@@ -145,9 +145,6 @@
virtual void ShowCreatedWidgetInternal(RenderWidgetHostView* widget_host_view,
const gfx::Rect& initial_pos);
- protected:
- WebContents* web_contents_;
-
private:
// We implement these functions on RenderViewHostDelegate::View directly and
// do some book-keeping associated with the request. The request is then
@@ -161,6 +158,9 @@
bool user_gesture);
virtual void ShowCreatedWidget(int route_id, const gfx::Rect& initial_pos);
+ // The WebContents whose contents we display.
+ WebContents* web_contents_;
+
// Tracks created WebContents objects that have not been shown yet. They are
// identified by the route ID passed to CreateNewWindow.
typedef std::map<int, WebContents*> PendingContents;
« no previous file with comments | « no previous file | chrome/browser/tab_contents/web_contents_view_gtk.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698