Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 4855001: Add qcms library for applying ICC color profile transforms to images. This... (Closed)

Created:
10 years, 1 month ago by abarth-chromium
Modified:
9 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews, Peter Kasting
Visibility:
Public.

Description

Add qcms library for applying ICC color profile transforms to images. This library is currently unused.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3211 lines, -0 lines) Patch
M build/all.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/qcms/Makefile.in View 1 chunk +70 lines, -0 lines 0 comments Download
A third_party/qcms/README.chromium View 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/qcms/iccread.c View 1 chunk +822 lines, -0 lines 0 comments Download
A third_party/qcms/qcms.h View 1 chunk +153 lines, -0 lines 0 comments Download
A third_party/qcms/qcms.gyp View 1 chunk +33 lines, -0 lines 0 comments Download
A third_party/qcms/qcmsint.h View 1 chunk +172 lines, -0 lines 0 comments Download
A third_party/qcms/qcmstypes.h View 1 chunk +84 lines, -0 lines 0 comments Download
A third_party/qcms/transform.c View 1 chunk +1372 lines, -0 lines 0 comments Download
A third_party/qcms/transform-sse1.c View 1 chunk +253 lines, -0 lines 0 comments Download
A third_party/qcms/transform-sse2.c View 1 chunk +243 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
10 years, 1 month ago (2010-11-11 23:45:38 UTC) #1
brettw
LGTM On Thu, Nov 11, 2010 at 3:45 PM, <abarth@chromium.org> wrote: > Reviewers: brettw, > ...
10 years, 1 month ago (2010-11-12 05:44:38 UTC) #2
abarth-chromium
10 years, 1 month ago (2010-11-12 06:06:39 UTC) #3
Thanks!

On Thu, Nov 11, 2010 at 9:44 PM, Brett Wilson <brettw@chromium.org> wrote:
> LGTM
>
> On Thu, Nov 11, 2010 at 3:45 PM,  <abarth@chromium.org> wrote:
>> Reviewers: brettw,
>>
>> Description:
>> Add qcms library for applying ICC color profile transforms to images.  This
>> library is currently unused.
>>
>>
>> Please review this at http://codereview.chromium.org/4855001/
>>
>> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>>
>> Affected files:
>>  M     build/all.gyp
>>  M     chrome/chrome.gyp
>>  A     third_party/qcms/Makefile.in
>>  A     third_party/qcms/README.chromium
>>  A     third_party/qcms/iccread.c
>>  A     third_party/qcms/qcms.gyp
>>  A     third_party/qcms/qcms.h
>>  A     third_party/qcms/qcmsint.h
>>  A     third_party/qcms/qcmstypes.h
>>  A     third_party/qcms/transform-sse1.c
>>  A     third_party/qcms/transform-sse2.c
>>  A     third_party/qcms/transform.c
>>
>>
>>
>

Powered by Google App Engine
This is Rietveld 408576698