Simplify gyp files by adding a global glob for openssl/nss

Simplify gyp files by adding a global glob for openssl/nss


BUG=None
TEST=Build

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66120

[wtc, 2010-11-12 14:47:49]

Good patch.  I have one suggested change and one question
below.

http://codereview.chromium.org/4799003/diff/2001/build/common.gypi
File build/common.gypi (right):

http://codereview.chromium.org/4799003/diff/2001/build/common.gypi#newcode658
build/common.gypi:658: ['exclude', '_nss\\.(cc|c)$'],
These patterns, except '/nss/', don't match the .h files,
which should also be excluded.

http://codereview.chromium.org/4799003/diff/2001/build/common.gypi#newcode660
build/common.gypi:660: ['exclude', '(/|_|^)nss_[^/]*\\.(cc|c)$'],
What's the [^/] part for?  To disallow '/'?
(I am not that familiar with glob patterns.)

[joth, 2010-11-12 14:56:38]

Thanks for the quick review!

http://codereview.chromium.org/4799003/diff/2001/build/common.gypi
File build/common.gypi (right):

http://codereview.chromium.org/4799003/diff/2001/build/common.gypi#newcode658
build/common.gypi:658: ['exclude', '_nss\\.(cc|c)$'],
On 2010/11/12 14:47:50, wtc wrote:
> These patterns, except '/nss/', don't match the .h files,
> which should also be excluded.

I agree -- reason I didn't is none of the ones above do.. ['exclude',
'_win(_unittest)?\\.cc$'], ['exclude', '_linux(_unittest)?\\.cc$'], etc

http://codereview.chromium.org/4799003/diff/2001/build/common.gypi#newcode660
build/common.gypi:660: ['exclude', '(/|_|^)nss_[^/]*\\.(cc|c)$'],
On 2010/11/12 14:47:50, wtc wrote:
> What's the [^/] part for?  To disallow '/'?
> (I am not that familiar with glob patterns.)

exactly. So this matches nss_util.cc and foo_nss_unittest.cc, but not
nss_foo/something.cc

[wtc, 2010-11-12 15:06:40]

http://codereview.chromium.org/4799003/diff/2001/build/common.gypi
File build/common.gypi (right):

http://codereview.chromium.org/4799003/diff/2001/build/common.gypi#newcode658
build/common.gypi:658: ['exclude', '_nss\\.(cc|c)$'],
On 2010/11/12 14:56:38, joth wrote:
>
> I agree -- reason I didn't is none of the ones above do.. ['exclude',
> '_win(_unittest)?\\.cc$'], ['exclude', '_linux(_unittest)?\\.cc$'], etc

I see.  We should request the help of a GYP expert (Brad
Nelson or Mark Mentovai) on this issue as in the original
code we exclude the .h files (using 'sources!').

Other than this issue, this patch looks good to me.