Simplify gyp files by adding a global glob for openssl/nss

build/common.gypi

 # Copyright (c) 2010 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # IMPORTANT:
 # Please don't directly include this file if you are building via gyp_chromium,
 # since gyp_chromium is automatically forcing its inclusion.
 {
   'variables': {
     # .gyp files or targets should set chromium_code to 1 if they build
@@ skipping 635 matching lines @@
                 'AdditionalOptions': ['/we4389'],
               },
             },
           }],
           ['chromeos!=1', {
             'sources/': [ ['exclude', '_chromeos\\.cc$'] ]
           }],
           ['toolkit_views==0', {
             'sources/': [ ['exclude', '_views\\.cc$'] ]
           }],
+          ['use_openssl==1', {
+            'sources/': [
+              ['exclude', '_nss\\.(cc|c)$'],

[wtc, 2010/11/12 14:47:50]

These patterns, except '/nss/', don't match the .h files,
which should also be excluded.

[joth, 2010/11/12 14:56:38]

I agree -- reason I didn't is none of the ones above do.. ['exclude',
'_win(_unittest)?\\.cc$'], ['exclude', '_linux(_unittest)?\\.cc$'], etc

[wtc, 2010/11/12 15:06:40]

I see.  We should request the help of a GYP expert (Brad
Nelson or Mark Mentovai) on this issue as in the original
code we exclude the .h files (using 'sources!').

Other than this issue, this patch looks good to me.

+              ['exclude', '/nss/'],
+              ['exclude', '(/|_|^)nss_[^/]*\\.(cc|c)$'],

[wtc, 2010/11/12 14:47:50]

What's the [^/] part for?  To disallow '/'?
(I am not that familiar with glob patterns.)

[joth, 2010/11/12 14:56:38]

exactly. So this matches nss_util.cc and foo_nss_unittest.cc, but not
nss_foo/something.cc

+            ],
+          }, {
+            'sources/': [
+              ['exclude', '_openssl\\.cc$'],
+              ['exclude', '(/|_|^)openssl_[^/]*\\.cc$'],
+            ],
+          }],
         ],
       }],
     ],  # target_conditions for 'target_defaults'
     'default_configuration': 'Debug',
     'configurations': {
       # VCLinkerTool LinkIncremental values below:
       #   0 == default
       #   1 == /INCREMENTAL:NO
       #   2 == /INCREMENTAL
       # Debug links incremental, Release does not.
@@ skipping 864 matching lines @@
     # and therefore SYMROOT, needs to be set at the project level.
     'SYMROOT': '<(DEPTH)/xcodebuild',
   },
 }
 
 # Local Variables:
 # tab-width:2
 # indent-tabs-mode:nil
 # End:
 # vim: set expandtab tabstop=2 shiftwidth=2: