Simplify gyp files by adding a global glob for openssl/nss

build/common.gypi

Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index c9f219ec5a79fca42b64fc13d2dbb9ddac9c4fe3..bd51828e5e63cef40b2fba94c4226cb3fd6085e6 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -653,6 +653,18 @@
           ['toolkit_views==0', {
             'sources/': [ ['exclude', '_views\\.cc$'] ]
           }],
+          ['use_openssl==1', {
+            'sources/': [
+              ['exclude', '_nss\\.(cc|c)$'],

[wtc, 2010/11/12 14:47:50]

These patterns, except '/nss/', don't match the .h files,
which should also be excluded.

[joth, 2010/11/12 14:56:38]

I agree -- reason I didn't is none of the ones above do.. ['exclude',
'_win(_unittest)?\\.cc$'], ['exclude', '_linux(_unittest)?\\.cc$'], etc

[wtc, 2010/11/12 15:06:40]

I see.  We should request the help of a GYP expert (Brad
Nelson or Mark Mentovai) on this issue as in the original
code we exclude the .h files (using 'sources!').

Other than this issue, this patch looks good to me.

+              ['exclude', '/nss/'],
+              ['exclude', '(/|_|^)nss_[^/]*\\.(cc|c)$'],

[wtc, 2010/11/12 14:47:50]

What's the [^/] part for?  To disallow '/'?
(I am not that familiar with glob patterns.)

[joth, 2010/11/12 14:56:38]

exactly. So this matches nss_util.cc and foo_nss_unittest.cc, but not
nss_foo/something.cc

+            ],
+          }, {
+            'sources/': [
+              ['exclude', '_openssl\\.cc$'],
+              ['exclude', '(/|_|^)openssl_[^/]*\\.cc$'],
+            ],
+          }],
         ],
       }],
     ],  # target_conditions for 'target_defaults'