Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 477113006: Use a real version string for app_shell (Closed)

Created:
6 years, 4 months ago by James Cook
Modified:
6 years, 4 months ago
Reviewers:
Daniel Erat
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Use a real version string for app_shell This ensures that the NaCl validation caches are flushed when a new version of app_shell is built. BUG=402612 TEST=coming in next CL (I need to add an app_shell_unittests target) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290640

Patch Set 1 #

Total comments: 2

Patch Set 2 : typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M extensions/shell/browser/shell_nacl_browser_delegate.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M extensions/shell/common/version.h.in View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
James Cook
derat, PTAL
6 years, 4 months ago (2014-08-19 18:18:46 UTC) #1
Daniel Erat
lgtm https://codereview.chromium.org/477113006/diff/1/extensions/shell/browser/shell_nacl_browser_delegate.cc File extensions/shell/browser/shell_nacl_browser_delegate.cc (right): https://codereview.chromium.org/477113006/diff/1/extensions/shell/browser/shell_nacl_browser_delegate.cc#newcode113 extensions/shell/browser/shell_nacl_browser_delegate.cc:113: // A version changes triggers an update of ...
6 years, 4 months ago (2014-08-19 18:25:14 UTC) #2
James Cook
https://codereview.chromium.org/477113006/diff/1/extensions/shell/browser/shell_nacl_browser_delegate.cc File extensions/shell/browser/shell_nacl_browser_delegate.cc (right): https://codereview.chromium.org/477113006/diff/1/extensions/shell/browser/shell_nacl_browser_delegate.cc#newcode113 extensions/shell/browser/shell_nacl_browser_delegate.cc:113: // A version changes triggers an update of the ...
6 years, 4 months ago (2014-08-19 18:27:44 UTC) #3
James Cook
The CQ bit was checked by jamescook@chromium.org
6 years, 4 months ago (2014-08-19 18:27:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/477113006/20001
6 years, 4 months ago (2014-08-19 18:28:46 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-19 19:59:35 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (20001) as 290640

Powered by Google App Engine
This is Rietveld 408576698