Use a real version string for app_shell

extensions/shell/browser/shell_nacl_browser_delegate.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/shell/browser/shell_nacl_browser_delegate.h"
 
 #include <string>
 
 #include "base/command_line.h"
 #include "base/path_service.h"
 #include "base/strings/string_split.h"
 #include "base/strings/string_util.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/site_instance.h"
 #include "extensions/browser/extension_system.h"
 #include "extensions/browser/info_map.h"
 #include "extensions/browser/process_manager.h"
 #include "extensions/common/constants.h"
 #include "extensions/common/extension.h"
 #include "extensions/common/url_pattern.h"
+#include "extensions/shell/common/version.h"  // Generated file.
 #include "ppapi/c/private/ppb_nacl_private.h"
 #include "url/gurl.h"
 
 using content::BrowserContext;
 using content::BrowserThread;
 using content::BrowserPpapiHost;
 
 namespace extensions {
 namespace {
 
@@ skipping 69 matching lines @@
 bool ShellNaClBrowserDelegate::GetUserDirectory(base::FilePath* user_dir) {
   base::FilePath path = browser_context_->GetPath();
   if (!path.empty()) {
     *user_dir = path;
     return true;
   }
   return false;
 }
 
 std::string ShellNaClBrowserDelegate::GetVersionString() const {
-  // Used to trigger update of the validation caches.
-  // TODO(jamescook): Generate a real version number and use it both here and
-  // in our user agent. http://crbug.com/402612
-  return "1.2.3.4";
+  // A version changes triggers an update of the NaCl validation caches.

[Daniel Erat, 2014/08/19 18:25:14]

nit: s/changes/change/

[James Cook, 2014/08/19 18:27:44]

Done.

+  // Example version: "39.0.2129.0 (290550)".
+  return PRODUCT_VERSION " (" LAST_CHANGE ")";
 }
 
 ppapi::host::HostFactory* ShellNaClBrowserDelegate::CreatePpapiHostFactory(
     content::BrowserPpapiHost* ppapi_host) {
   return NULL;
 }
 
 void ShellNaClBrowserDelegate::SetDebugPatterns(std::string debug_patterns) {
   // No debugger support. Developers should use Chrome for debugging.
 }
@@ skipping 54 matching lines @@
   return base::Bind(&OnKeepalive);
 }
 
 bool ShellNaClBrowserDelegate::IsNonSfiModeAllowed(
     const base::FilePath& profile_directory,
     const GURL& manifest_url) {
   return false;
 }
 
 }  // namespace extensions