Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1635)

Unified Diff: extensions/shell/browser/shell_nacl_browser_delegate.cc

Issue 477113006: Use a real version string for app_shell (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: typo Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | extensions/shell/common/version.h.in » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/shell/browser/shell_nacl_browser_delegate.cc
diff --git a/extensions/shell/browser/shell_nacl_browser_delegate.cc b/extensions/shell/browser/shell_nacl_browser_delegate.cc
index a9b01e0dde49508a73bc8b9bca722b0f39a3f339..778763b0b4b6c14b56a023f23b83bee1ed48ae85 100644
--- a/extensions/shell/browser/shell_nacl_browser_delegate.cc
+++ b/extensions/shell/browser/shell_nacl_browser_delegate.cc
@@ -20,6 +20,7 @@
#include "extensions/common/constants.h"
#include "extensions/common/extension.h"
#include "extensions/common/url_pattern.h"
+#include "extensions/shell/common/version.h" // Generated file.
#include "ppapi/c/private/ppb_nacl_private.h"
#include "url/gurl.h"
@@ -109,10 +110,9 @@ bool ShellNaClBrowserDelegate::GetUserDirectory(base::FilePath* user_dir) {
}
std::string ShellNaClBrowserDelegate::GetVersionString() const {
- // Used to trigger update of the validation caches.
- // TODO(jamescook): Generate a real version number and use it both here and
- // in our user agent. http://crbug.com/402612
- return "1.2.3.4";
+ // A version change triggers an update of the NaCl validation caches.
+ // Example version: "39.0.2129.0 (290550)".
+ return PRODUCT_VERSION " (" LAST_CHANGE ")";
}
ppapi::host::HostFactory* ShellNaClBrowserDelegate::CreatePpapiHostFactory(
« no previous file with comments | « no previous file | extensions/shell/common/version.h.in » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698