Chromium Code Reviews

Issue 4694008: Make pink's TabContentsWrapper change compile on Windows.... (Closed)

Created:
10 years, 1 month ago by Ben Goodger (Google)
Modified:
9 years, 6 months ago
Reviewers:
CC:
chromium-reviews, ncarter (slow), idana, ben+cc_chromium.org, Raghu Simha, Erik does not do reviews, Paweł Hajdan Jr., Aaron Boodman, pam+watch_chromium.org, brettw-cc_chromium.org, tim (not reviewing)
Visibility:
Public.

Description

Make pink's TabContentsWrapper change compile on Windows. Code by pinkerton@, with modifications by evanm and myself to get it to build on windows/linux/chromeos. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66626

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Stats (+1750 lines, -1244 lines)
M chrome/browser/aeropeek_manager.h View 1 chunk +7 lines, -7 lines 0 comments
M chrome/browser/aeropeek_manager.cc View 6 chunks +28 lines, -22 lines 0 comments
M chrome/browser/automation/automation_provider_observers.h View 1 chunk +2 lines, -2 lines 0 comments
M chrome/browser/automation/automation_provider_observers.cc View 2 chunks +4 lines, -2 lines 0 comments
M chrome/browser/automation/testing_automation_provider.cc View 3 chunks +3 lines, -4 lines 0 comments
M chrome/browser/browser_browsertest.cc View 5 chunks +13 lines, -9 lines 0 comments
M chrome/browser/chromeos/tab_closeable_state_watcher.h View 1 chunk +4 lines, -4 lines 0 comments
M chrome/browser/chromeos/tab_closeable_state_watcher.cc View 3 chunks +10 lines, -6 lines 0 comments
M chrome/browser/chromeos/tab_closeable_state_watcher_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments
M chrome/browser/chromeos/wm_overview_controller.cc View 7 chunks +20 lines, -18 lines 0 comments
M chrome/browser/cocoa/applescript/window_applescript.mm View 3 chunks +8 lines, -6 lines 0 comments
M chrome/browser/cocoa/bookmarks/bookmark_all_tabs_controller.mm View 2 chunks +2 lines, -1 line 0 comments
M chrome/browser/cocoa/bookmarks/bookmark_bar_controller.mm View 1 chunk +2 lines, -3 lines 0 comments
M chrome/browser/cocoa/browser_window_cocoa.h View 1 chunk +1 line, -1 line 0 comments
M chrome/browser/cocoa/browser_window_cocoa.mm View 4 chunks +5 lines, -4 lines 0 comments
M chrome/browser/cocoa/browser_window_controller.mm View 5 chunks +6 lines, -5 lines 0 comments
M chrome/browser/cocoa/location_bar/location_bar_view_mac.mm View 1 chunk +1 line, -1 line 0 comments
M chrome/browser/cocoa/tab_strip_controller.h View 1 chunk +1 line, -1 line 0 comments
M chrome/browser/cocoa/tab_strip_controller.mm View 19 chunks +43 lines, -32 lines 0 comments
M chrome/browser/cocoa/tab_strip_controller_unittest.mm View 4 chunks +13 lines, -12 lines 0 comments
M chrome/browser/cocoa/tab_strip_model_observer_bridge.h View 3 chunks +21 lines, -21 lines 0 comments
M chrome/browser/cocoa/tab_strip_model_observer_bridge.mm View 8 chunks +16 lines, -14 lines 0 comments
M chrome/browser/cocoa/tabpose_window.mm View 8 chunks +12 lines, -10 lines 0 comments
M chrome/browser/cocoa/tabpose_window_unittest.mm View 2 chunks +2 lines, -1 line 0 comments
M chrome/browser/debugger/devtools_http_protocol_handler.cc View 3 chunks +4 lines, -2 lines 0 comments
M chrome/browser/debugger/devtools_window.h View 3 chunks +3 lines, -3 lines 0 comments
M chrome/browser/debugger/devtools_window.cc View 6 chunks +12 lines, -7 lines 0 comments
M chrome/browser/debugger/inspectable_tab_proxy.cc View 1 chunk +1 line, -0 lines 0 comments
M chrome/browser/dom_ui/html_dialog_tab_contents_delegate.cc View 2 chunks +6 lines, -2 lines 0 comments
M chrome/browser/extensions/execute_code_in_tab_function.cc View 5 chunks +6 lines, -5 lines 0 comments
M chrome/browser/extensions/extension_browser_event_router.h View 1 chunk +12 lines, -10 lines 0 comments
M chrome/browser/extensions/extension_browser_event_router.cc View 11 chunks +46 lines, -39 lines 0 comments
M chrome/browser/extensions/extension_browsertests_misc.cc View 2 chunks +2 lines, -1 line 0 comments
M chrome/browser/extensions/extension_clipboard_api.cc View 2 chunks +2 lines, -1 line 0 comments
M chrome/browser/extensions/extension_cookies_helpers.cc View 2 chunks +3 lines, -1 line 0 comments
M chrome/browser/extensions/extension_devtools_bridge.cc View 2 chunks +2 lines, -1 line 0 comments
M chrome/browser/extensions/extension_devtools_browsertests.cc View 2 chunks +2 lines, -2 lines 0 comments
M chrome/browser/extensions/extension_infobar_module.cc View 3 chunks +5 lines, -3 lines 0 comments
M chrome/browser/extensions/extension_message_service.cc View 2 chunks +2 lines, -1 line 0 comments
M chrome/browser/extensions/extension_page_actions_module.cc View 4 chunks +7 lines, -4 lines 0 comments
M chrome/browser/extensions/extension_processes_api.cc View 3 chunks +4 lines, -2 lines 0 comments
M chrome/browser/extensions/extension_sidebar_api.cc View 4 chunks +4 lines, -3 lines 0 comments
M chrome/browser/extensions/extension_tabs_module.h View 1 chunk +27 lines, -27 lines 0 comments
M chrome/browser/extensions/extension_tabs_module.cc View 21 chunks +36 lines, -32 lines 0 comments
M chrome/browser/gtk/browser_window_gtk.h View 2 chunks +4 lines, -4 lines 0 comments
M chrome/browser/gtk/browser_window_gtk.cc View 5 chunks +16 lines, -15 lines 0 comments
M chrome/browser/gtk/location_bar_view_gtk.cc View 1 chunk +1 line, -1 line 0 comments
M chrome/browser/gtk/tabs/dragged_tab_controller_gtk.h View 3 chunks +3 lines, -2 lines 0 comments
M chrome/browser/gtk/tabs/dragged_tab_controller_gtk.cc View 7 chunks +11 lines, -9 lines 0 comments
M chrome/browser/gtk/tabs/tab_strip_gtk.h View 1 chunk +10 lines, -10 lines 0 comments
M chrome/browser/gtk/tabs/tab_strip_gtk.cc View 11 chunks +36 lines, -17 lines 0 comments
M chrome/browser/instant/instant_browsertest.cc View 2 chunks +2 lines, -1 line 0 comments
M chrome/browser/instant/instant_controller.h View 4 chunks +6 lines, -5 lines 0 comments
M chrome/browser/instant/instant_controller.cc View 6 chunks +11 lines, -9 lines 0 comments
M chrome/browser/instant/instant_delegate.h View 3 chunks +3 lines, -3 lines 0 comments
M chrome/browser/instant/instant_loader.h View 5 chunks +7 lines, -4 lines 0 comments
M chrome/browser/instant/instant_loader.cc View 11 chunks +23 lines, -19 lines 0 comments
M chrome/browser/instant/instant_loader_manager.cc View 2 chunks +2 lines, -1 line 0 comments
M chrome/browser/login_prompt.h View 1 chunk +0 lines, -1 line 0 comments
M chrome/browser/login_prompt.cc View 2 chunks +7 lines, -2 lines 0 comments
M chrome/browser/password_manager/password_manager.h View 4 chunks +24 lines, -22 lines 0 comments
M chrome/browser/password_manager/password_manager.cc View 1 chunk +1 line, -0 lines 0 comments
A chrome/browser/password_manager_delegate_impl.h View 1 chunk +29 lines, -0 lines 0 comments
A chrome/browser/password_manager_delegate_impl.cc View 1 chunk +120 lines, -0 lines 0 comments
M chrome/browser/printing/print_preview_tab_controller.cc View 2 chunks +7 lines, -6 lines 0 comments
M chrome/browser/printing/print_preview_tab_controller_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments
M chrome/browser/ssl/ssl_browser_tests.cc View 8 chunks +14 lines, -13 lines 0 comments
M chrome/browser/tab_contents/tab_contents.h View 10 chunks +11 lines, -20 lines 0 comments
M chrome/browser/tab_contents/tab_contents.cc View 13 chunks +28 lines, -134 lines 0 comments
A chrome/browser/tab_contents/web_navigation_observer.h View 1 chunk +57 lines, -0 lines 1 comment
A chrome/browser/tab_contents_wrapper.h View 1 chunk +75 lines, -0 lines 0 comments
A chrome/browser/tab_contents_wrapper.cc View 1 chunk +49 lines, -0 lines 0 comments
M chrome/browser/tabs/default_tab_handler.h View 2 chunks +27 lines, -25 lines 0 comments
M chrome/browser/tabs/default_tab_handler.cc View 6 chunks +20 lines, -17 lines 0 comments
M chrome/browser/tabs/pinned_tab_codec.cc View 2 chunks +2 lines, -1 line 0 comments
M chrome/browser/tabs/tab_strip_model.h View 12 chunks +34 lines, -22 lines 0 comments
M chrome/browser/tabs/tab_strip_model.cc View 24 chunks +65 lines, -39 lines 0 comments
M chrome/browser/tabs/tab_strip_model_delegate.h View 6 chunks +8 lines, -7 lines 0 comments
M chrome/browser/tabs/tab_strip_model_observer.h View 3 chunks +14 lines, -14 lines 0 comments
M chrome/browser/tabs/tab_strip_model_observer.cc View 1 chunk +16 lines, -13 lines 0 comments
M chrome/browser/tabs/tab_strip_model_order_controller.h View 3 chunks +4 lines, -4 lines 0 comments
M chrome/browser/tabs/tab_strip_model_order_controller.cc View 3 chunks +7 lines, -6 lines 0 comments
M chrome/browser/tabs/tab_strip_model_unittest.cc View 62 chunks +171 lines, -158 lines 0 comments
M chrome/browser/ui/browser.h View 8 chunks +48 lines, -28 lines 0 comments
M chrome/browser/ui/browser.cc View 60 chunks +157 lines, -116 lines 0 comments
M chrome/browser/ui/browser_init.cc View 2 chunks +3 lines, -2 lines 0 comments
M chrome/browser/ui/browser_navigator.h View 3 chunks +4 lines, -4 lines 0 comments
M chrome/browser/ui/browser_navigator.cc View 10 chunks +26 lines, -19 lines 0 comments
M chrome/browser/ui/browser_navigator_browsertest.cc View 8 chunks +14 lines, -12 lines 0 comments
M chrome/browser/ui/browser_window.h View 2 chunks +2 lines, -1 line 0 comments
M chrome/browser/ui/views/frame/browser_view.h View 5 chunks +17 lines, -14 lines 0 comments
M chrome/browser/ui/views/frame/browser_view.cc View 19 chunks +31 lines, -25 lines 0 comments
M chrome/browser/ui/views/location_bar/click_handler.cc View 2 chunks +2 lines, -1 line 0 comments
M chrome/browser/ui/views/location_bar/content_setting_image_view.cc View 2 chunks +2 lines, -1 line 0 comments
M chrome/browser/ui/views/location_bar/location_bar_view.h View 3 chunks +4 lines, -3 lines 0 comments
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 10 chunks +19 lines, -16 lines 0 comments
M chrome/browser/ui/views/tabs/browser_tab_strip_controller.h View 3 chunks +16 lines, -13 lines 0 comments
M chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc View 7 chunks +27 lines, -22 lines 0 comments
M chrome/browser/ui/views/tabs/dragged_tab_controller.h View 4 chunks +5 lines, -4 lines 0 comments
M chrome/browser/ui/views/tabs/dragged_tab_controller.cc View 7 chunks +11 lines, -9 lines 0 comments
M chrome/browser/ui/views/toolbar_view.h View 1 chunk +1 line, -1 line 0 comments
M chrome/browser/ui/views/toolbar_view.cc View 1 chunk +2 lines, -2 lines 0 comments
M chrome/browser/wrench_menu_model.h View 1 chunk +4 lines, -4 lines 0 comments
M chrome/browser/wrench_menu_model.cc View 2 chunks +5 lines, -4 lines 0 comments
M chrome/chrome_browser.gypi View 2 chunks +5 lines, -0 lines 0 comments
M chrome/common/property_bag.h View 1 chunk +2 lines, -2 lines 0 comments
M chrome/test/browser_with_test_window_test.cc View 1 chunk +1 line, -0 lines 0 comments
M chrome/test/live_sync/live_sessions_sync_test.h View 2 chunks +2 lines, -1 line 0 comments
M chrome/test/test_browser_window.h View 1 chunk +1 line, -1 line 0 comments

Messages

Total messages: 2 (0 generated)
Ben Goodger (Google)
http://codereview.chromium.org/4694008/diff/323001/chrome/browser/tab_contents/web_navigation_observer.h File chrome/browser/tab_contents/web_navigation_observer.h (right): http://codereview.chromium.org/4694008/diff/323001/chrome/browser/tab_contents/web_navigation_observer.h#newcode35 chrome/browser/tab_contents/web_navigation_observer.h:35: // TODO(pinkerton): Not sure the best place for these. ...
10 years, 1 month ago (2010-11-17 21:07:19 UTC) #1
Ben Goodger (Google)
10 years, 1 month ago (2010-11-17 21:08:47 UTC) #2 
This change LGTM btw, it is obviously incomplete but a necessary first step in
the right direction.

Powered by Google App Engine