Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5994)

Unified Diff: chrome/browser/ssl/ssl_browser_tests.cc

Issue 4694008: Make pink's TabContentsWrapper change compile on Windows.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ssl/ssl_browser_tests.cc
===================================================================
--- chrome/browser/ssl/ssl_browser_tests.cc (revision 66453)
+++ chrome/browser/ssl/ssl_browser_tests.cc (working copy)
@@ -9,6 +9,7 @@
#include "chrome/browser/tab_contents/interstitial_page.h"
#include "chrome/browser/tab_contents/navigation_entry.h"
#include "chrome/browser/tab_contents/tab_contents.h"
+#include "chrome/browser/tab_contents_wrapper.h"
#include "chrome/browser/tabs/tab_strip_model.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_navigator.h"
@@ -396,7 +397,7 @@
ASSERT_TRUE(https_server_expired_.Start());
GURL url = https_server_expired_.GetURL("files/ssl/google.htm");
- TabContents* tab2 =
+ TabContentsWrapper* tab2 =
browser()->AddSelectedTabWithURL(url, PageTransition::TYPED);
ui_test_utils::WaitForLoadStop(&(tab2->controller()));
@@ -404,7 +405,7 @@
EXPECT_FALSE(browser()->command_updater()->IsCommandEnabled(IDC_BACK));
// We should have an interstitial page showing.
- ASSERT_TRUE(tab2->interstitial_page());
+ ASSERT_TRUE(tab2->tab_contents()->interstitial_page());
}
//
@@ -526,10 +527,10 @@
ui_test_utils::NavigateToURL(browser(),
https_server_.GetURL("files/ssl/blank_page.html"));
- TabContents* tab1 = browser()->GetSelectedTabContents();
+ TabContentsWrapper* tab1 = browser()->GetSelectedTabContentsWrapper();
// This tab should be fine.
- CheckAuthenticatedState(tab1, false);
+ CheckAuthenticatedState(tab1->tab_contents(), false);
// Create a new tab.
std::string replacement_path;
@@ -544,14 +545,14 @@
params.tabstrip_index = 0;
params.source_contents = tab1;
browser::Navigate(&params);
- TabContents* tab2 = params.target_contents;
+ TabContentsWrapper* tab2 = params.target_contents;
ui_test_utils::WaitForNavigation(&(tab2->controller()));
// The new tab has insecure content.
- CheckAuthenticatedState(tab2, true);
+ CheckAuthenticatedState(tab2->tab_contents(), true);
// The original tab should not be contaminated.
- CheckAuthenticatedState(tab1, false);
+ CheckAuthenticatedState(tab1->tab_contents(), false);
}
// Visits two pages from the same origin: one that runs insecure content and one
@@ -564,10 +565,10 @@
ui_test_utils::NavigateToURL(browser(),
https_server_.GetURL("files/ssl/blank_page.html"));
- TabContents* tab1 = browser()->GetSelectedTabContents();
+ TabContentsWrapper* tab1 = browser()->GetSelectedTabContentsWrapper();
// This tab should be fine.
- CheckAuthenticatedState(tab1, false);
+ CheckAuthenticatedState(tab1->tab_contents(), false);
std::string replacement_path;
ASSERT_TRUE(GetFilePathWithHostAndPortReplacement(
@@ -581,15 +582,15 @@
params.disposition = NEW_FOREGROUND_TAB;
params.source_contents = tab1;
browser::Navigate(&params);
- TabContents* tab2 = params.target_contents;
+ TabContentsWrapper* tab2 = params.target_contents;
ui_test_utils::WaitForNavigation(&(tab2->controller()));
// The new tab has insecure content.
- CheckAuthenticationBrokenState(tab2, 0, true, false);
+ CheckAuthenticationBrokenState(tab2->tab_contents(), 0, true, false);
// Which means the origin for the first tab has also been contaminated with
// insecure content.
- CheckAuthenticationBrokenState(tab1, 0, true, false);
+ CheckAuthenticationBrokenState(tab1->tab_contents(), 0, true, false);
}
// Visits a page with an image over http. Visits another page over https
@@ -743,7 +744,7 @@
// Let's add another tab to make sure the browser does not exit when we close
// the first tab.
GURL url = test_server()->GetURL("files/ssl/google.html");
- TabContents* tab2 =
+ TabContentsWrapper* tab2 =
browser()->AddSelectedTabWithURL(url, PageTransition::TYPED);
ui_test_utils::WaitForNavigation(&(tab2->controller()));

Powered by Google App Engine
This is Rietveld 408576698