Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: chrome/browser/extensions/extension_tabs_module.h

Issue 4694008: Make pink's TabContentsWrapper change compile on Windows.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_tabs_module.h
===================================================================
--- chrome/browser/extensions/extension_tabs_module.h (revision 66453)
+++ chrome/browser/extensions/extension_tabs_module.h (working copy)
@@ -19,35 +19,35 @@
class ListValue;
class SkBitmap;
class TabContents;
+class TabContentsWrapper;
class TabStripModel;
-class ExtensionTabUtil {
- public:
- static int GetWindowId(const Browser* browser);
- static int GetTabId(const TabContents* tab_contents);
- static std::string GetTabStatusText(bool is_loading);
- static int GetWindowIdOfTab(const TabContents* tab_contents);
- static ListValue* CreateTabList(const Browser* browser);
- static DictionaryValue* CreateTabValue(const TabContents* tab_contents);
- static DictionaryValue* CreateTabValue(const TabContents* tab_contents,
- TabStripModel* tab_strip,
- int tab_index);
- static DictionaryValue* CreateWindowValue(const Browser* browser,
- bool populate_tabs);
- // Gets the |tab_strip_model| and |tab_index| for the given |tab_contents|.
- static bool GetTabStripModel(const TabContents* tab_contents,
- TabStripModel** tab_strip_model,
- int* tab_index);
- static bool GetDefaultTab(Browser* browser, TabContents** contents,
- int* tab_id);
- // Any out parameter (|browser|, |tab_strip|, |contents|, & |tab_index|) may
- // be NULL and will not be set within the function.
- static bool GetTabById(int tab_id, Profile* profile, bool incognito_enabled,
- Browser** browser,
- TabStripModel** tab_strip,
- TabContents** contents,
- int* tab_index);
-};
+namespace ExtensionTabUtil {
+int GetWindowId(const Browser* browser);
+int GetTabId(const TabContents* tab_contents);
+std::string GetTabStatusText(bool is_loading);
+int GetWindowIdOfTab(const TabContents* tab_contents);
+ListValue* CreateTabList(const Browser* browser);
+DictionaryValue* CreateTabValue(const TabContents* tab_contents);
+DictionaryValue* CreateTabValue(const TabContents* tab_contents,
+ TabStripModel* tab_strip,
+ int tab_index);
+DictionaryValue* CreateWindowValue(const Browser* browser,
+ bool populate_tabs);
+// Gets the |tab_strip_model| and |tab_index| for the given |tab_contents|.
+bool GetTabStripModel(const TabContents* tab_contents,
+ TabStripModel** tab_strip_model,
+ int* tab_index);
+bool GetDefaultTab(Browser* browser, TabContentsWrapper** contents,
+ int* tab_id);
+// Any out parameter (|browser|, |tab_strip|, |contents|, & |tab_index|) may
+// be NULL and will not be set within the function.
+bool GetTabById(int tab_id, Profile* profile, bool incognito_enabled,
+ Browser** browser,
+ TabStripModel** tab_strip,
+ TabContentsWrapper** contents,
+ int* tab_index);
+}
// Windows
class GetWindowFunction : public SyncExtensionFunction {

Powered by Google App Engine
This is Rietveld 408576698